Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug info for macOS CI actions #119829

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add debug info for macOS CI actions #119829

merged 1 commit into from
Jan 11, 2024

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 10, 2024

This adds some debugging information to the CI logs about the macOS runners to potentially help diagnose performance issues. I think this is unlikely to help, since I think the most likely issue is over-provisioning, but I figured it might be a worthy shot in the dark. The macos-12 runners definitely have issues with SIP randomly being enabled, but I have not seen evidence of that for macos-13.

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2024

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 10, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jan 10, 2024

I'm not familiar with macOS, but these commands look harmless. Let's see if they can help in debugging the slow runners.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 10, 2024

📌 Commit f7e8739 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2024
Rollup of 3 pull requests

Successful merges:

 - rust-lang#116343 (Stop mentioning internal lang items in no_std binary errors)
 - rust-lang#119814 (bootstrap: exclude link_jobs from `check_ci_llvm!` checks)
 - rust-lang#119829 (Add debug info for macOS CI actions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a7713d7 into rust-lang:master Jan 11, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2024
Rollup merge of rust-lang#119829 - ehuss:macos-sip, r=Kobzol

Add debug info for macOS CI actions

This adds some debugging information to the CI logs about the macOS runners to potentially help diagnose performance issues. I think this is unlikely to help, since I think the most likely issue is over-provisioning, but I figured it might be a worthy shot in the dark. The macos-12 runners definitely have issues with SIP randomly being enabled, but I have not seen evidence of that for macos-13.
@rustbot rustbot added this to the 1.77.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants