remove dead inferred outlives testing code #119248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
|
Should we do it the other way instead? Fix the |
7515ad3 to
49103dc
Compare
Sure, I've moved the test code from the query over to the test function. |
|
@bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 23, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119231 (Clairify `ast::PatKind::Struct` presese of `..` by using an enum instead of a bool) - rust-lang#119232 (Fix doc typos) - rust-lang#119245 (Improve documentation for using warning blocks in documentation) - rust-lang#119248 (remove dead inferred outlives testing code) - rust-lang#119249 (Add spastorino to users_on_vacation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 23, 2023
Rollup merge of rust-lang#119248 - lukas-code:purge-unused-outlives-test, r=cjgillot remove dead inferred outlives testing code The `test_inferred_outlives` function was never run, because the code that's actually used for the tests was part of the `inferred_outlives_of` query, which ran before `test_inferred_outlives` during type collecting. This PR separates the test code from the query and moves it inside the dedicated function.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2023
…r-errors Do not fetch HIR in inferred_outlives_of. Small simplification allowed by rust-lang#119248
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 25, 2023
…r-errors Do not fetch HIR in inferred_outlives_of. Small simplification allowed by rust-lang#119248
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 25, 2023
…r-errors Do not fetch HIR in inferred_outlives_of. Small simplification allowed by rust-lang#119248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_inferred_outlivesfunction was never run, because the code that's actually used for the tests was part of theinferred_outlives_ofquery, which ran beforetest_inferred_outlivesduring type collecting. This PR separates the test code from the query and moves it inside the dedicated function.