Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move section "Installing from Source" to seperate file #119189

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Move section "Installing from Source" to seperate file #119189

merged 1 commit into from
Jan 14, 2024

Conversation

henrispriet
Copy link
Contributor

cc #118627

@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Noratrieb
Noratrieb reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to edit files in .reuse to mention INSTALLING_FROM_SOURCE.md the same way it mentions README.md today to get CI working

README.md Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

I think this is a good idea. However, I think we should name the file just "INSTALL.md" or so, and include in the header of the file a repeat of the message that this is probably not what people want. Otherwise some % of people will see this file first when looking for "how to install", despite the suffix, and miss that disclaimer.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2023
@henrispriet
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 24, 2023
@Mark-Simulacrum
Copy link
Member

r=me with commits squashed

@Mark-Simulacrum
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2024
@henrispriet
Copy link
Contributor Author

@Mark-Simulacrum I don't understand what you would like me to change...

@Mark-Simulacrum
Copy link
Member

There's some docs here on squashing commits: https://rustc-dev-guide.rust-lang.org/git.html#squash-your-commits

@henrispriet henrispriet force-pushed the move-installing-from-source branch from 71c83ec to 994d11a Compare January 13, 2024 16:23
@henrispriet
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 13, 2024
@Noratrieb
Copy link
Member

@bors r=Mark-Simulacrum
Thank you for the PR!

@bors
Copy link
Contributor

bors commented Jan 13, 2024

📌 Commit 994d11a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2024
@Noratrieb
Copy link
Member

@bors rollup

Noratrieb added a commit to Noratrieb/rust that referenced this pull request Jan 13, 2024
@Noratrieb
Rollup merge of rust-lang#119189 - henrispriet:move-installing-from-s…
bc3837b 
…ource, r=Mark-Simulacrum

Move section "Installing from Source" to seperate file

cc rust-lang#118627
@Noratrieb Noratrieb mentioned this pull request Jan 13, 2024
Closed
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Jan 13, 2024
@Noratrieb
Rollup merge of rust-lang#119189 - henrispriet:move-installing-from-s…
dff33f7 
…ource, r=Mark-Simulacrum

Move section "Installing from Source" to seperate file

cc rust-lang#118627
@Noratrieb Noratrieb mentioned this pull request Jan 13, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2024
@bors
Auto merge of rust-lang#119945 - matthiaskrgr:rollup-oy3e1j2, r=matth…
3deb9bb 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119189 (Move section "Installing from Source" to seperate file)
 - rust-lang#119925 (store the segment name when resolution fails)
 - rust-lang#119935 (Move personality implementation out of PAL)
 - rust-lang#119937 (Improve UEFI target docs)
 - rust-lang#119938 (Allow unauthorized users to user the has-merge-commits label)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0bbc888 into rust-lang:master Jan 14, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
@rust-timer
Unrolled build for rust-lang#119189
afb33a1 
Rollup merge of rust-lang#119189 - henrispriet:move-installing-from-source, r=Mark-Simulacrum

Move section "Installing from Source" to seperate file

cc rust-lang#118627
@homersimpsons homersimpsons mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
6 participants
@henrispriet @rustbot @rust-log-analyzer @Mark-Simulacrum @Noratrieb @bors