-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make most rustc_type_ir
kinds Copy
by default
#118841
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
r? @BoxyUwU (rustbot has picked a reviewer for you, use r? to override) |
Make most `rustc_type_ir` kinds `Copy` by default 1. There's no reason why `TyKind` and `ConstKind`/`ConstData` can't be `Copy`. This allows us to avoid needing a typed arena for the two types. 2. Simplify some impls into derives.
This comment has been minimized.
This comment has been minimized.
It might be too late for this, but should be careful. At one point, rust-analyzer's types were not Copy. Not sure if that's still the case. |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
The non- As for the implementations I removed, I can re-add them if rust-analyzer needs them. Until then, I'd rather simplify the code. @lcnr also has discussed a bit with the r-a folks about needing |
Yeah, happy to simplify now and revert back things as needed! Just figured I'd bring this up. |
Finished benchmarking commit (e918fba): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.568s -> 670.86s (0.04%) |
cool @rustbot ready |
985f378
to
f3218b2
Compare
@bors r+ |
r? @jackh726 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (27d8a57): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.595s -> 673.136s (-0.07%) |
TyKind
andConstKind
/ConstData
can't beCopy
. This allows us to avoid needing a typed arena for the two types.