-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add error message for c# style named arguments #118532
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
Would I have to change the tests, since the error message is no longer the same? @estebank |
r? compiler |
r? compiler |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@nouritsu That output seems odd. Can you try to follow the instructions at https://rustc-dev-guide.rust-lang.org/tests/running.html? I wonder if there's some uncommon set-up in your environment for that error to happen. (raises fist at OSError not printing the path that caused the problem) Also, we don't include merge commits in PRs, we always rebase on top of a newer master. |
I'm not familiar with git, I will be opening a new pull request. |
Solves #116411
Result -