Specialize sleep_until implementation #118480

dvdsk · 2023-11-30T14:36:29Z

Draft (I need the CI tests, which will probably fail)
related tracking issue: #113752

Replaces the generic catch all implementation with target_os specific ones for: linux/netbsd/freebsd/android/solaris/illumos, wasi, macos/ios/tvos/watchos and windows.

Points of attention:

Adds extern "C" calls to mach_wait_until and mach_timebase_info for macos etc. We could also import them from the mach2 crate, but then we depend on mach2 and we need to modify mach2 to work as an std dep (adding a feature rustc-dep-of-std).
The implementations need access to the target_os specific details of the Instant type. For that I added an into_inner and made some fields public. Is there a neater way?
All untested, I only have access to an linux install. I hope the CI catches any issues.

rustbot · 2023-11-30T14:36:38Z

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

dvdsk · 2023-11-30T16:02:57Z

Not ready for review, however I need CI to run.

cuviper · 2023-11-30T19:29:46Z

We don't have a configured way to try full CI, but you can copy specific jobs from auto to pr here:

rust/src/ci/github-actions/ci.yml

Line 319 in b10cfcd

jobs:

Then ./x.py run src/tools/expand-yaml-anchors to update the real config, and push that as a temporary commit.

joboet

I tested this on my local macOS machine. While the implementation works, the test currently fails because its success margin is too small.

library/std/tests/thread.rs

library/std/src/thread/mod.rs

bors · 2023-12-07T08:28:36Z

☔ The latest upstream changes (presumably #116565) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2024-01-13T16:52:58Z

☔ The latest upstream changes (presumably #117285) made this pull request unmergeable. Please resolve the merge conflicts.

cuviper · 2024-01-25T19:12:49Z

I'm clearing this from my queue while it's in draft, but you can use ready when you are.

@rustbot author

Dylan-DPC · 2024-02-18T06:52:52Z

@dvdsk any updates on this pr? thanks

bors · 2024-10-26T00:14:23Z

☔ The latest upstream changes (presumably #132148) made this pull request unmergeable. Please resolve the merge conflicts.

It is not working and I can not figure out why. Since I am not familiar with developing on windows I might not be the best person to work on this. The work removed in this commit might be a useful jumping off point for anyone else however.

more unix platforms target_vendor's done by: Co-authored-by: Jonas Böttiger <jonasboettiger@icloud.com>

…inks Co-authored-by: joboet <jonasboettiger@icloud.com>

rust-log-analyzer · 2024-10-26T12:28:12Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#16 2.674 Building wheels for collected packages: reuse
#16 2.675   Building wheel for reuse (pyproject.toml): started
#16 2.916   Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 2.917   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#16 2.917   Stored in directory: /tmp/pip-ephem-wheel-cache-f9crtrnh/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 2.920 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.298 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.298 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.4s
---
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
23  | |      pub struct int8x8_t(pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crat...
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
27  | |      pub struct uint8x8_t(pub(crate) u8, pub(crate) u8, pub(crate) u8, pub(crate) u8, pub(crate) u8, pub(crate) u8, pub(crate) u8, pub(cra...
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
31  | |      pub struct poly8x8_t(pub(crate) p8, pub(crate) p8, pub(crate) p8, pub(crate) p8, pub(crate) p8, pub(crate) p8, pub(crate) p8, pub(cra...
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
35  | |      pub struct int16x4_t(pub(crate) i16, pub(crate) i16, pub(crate) i16, pub(crate) i16);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
39  | |      pub struct uint16x4_t(pub(crate) u16, pub(crate) u16, pub(crate) u16, pub(crate) u16);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
45  | |      pub struct poly16x4_t(pub(crate) p16, pub(crate) p16, pub(crate) p16, pub(crate) p16);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
49  | |      pub struct int32x2_t(pub(crate) i32, pub(crate) i32);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
53  | |      pub struct uint32x2_t(pub(crate) u32, pub(crate) u32);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
57  | |      pub struct float32x2_t(pub(crate) f32, pub(crate) f32);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
61  | |      pub struct int64x1_t(pub(crate) i64);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
65  | |      pub struct uint64x1_t(pub(crate) u64);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
69  | |      pub struct poly64x1_t(pub(crate) p64);
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
75  | |          pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8, pub(crate) i8 , pub(crate) i8, pub(crate) i8,
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
82  | |          pub(crate) u8, pub(crate) u8 , pub(crate) u8, pub(crate) u8, pub(crate) u8, pub(crate) u8 , pub(crate) u8, pub(crate) u8,
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
89  | |           pub(crate) p8,  pub(crate) p8,  pub(crate) p8,  pub(crate) p8,  pub(crate) p8,  pub(crate) p8,  pub(crate) p8,  pub(crate) p8,
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
95  | |      pub struct int16x8_t(pub(crate) i16, pub(crate) i16, pub(crate) i16, pub(crate) i16, pub(crate) i16, pub(crate) i16, pub(crate) i16, ...
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
99  | |      pub struct uint16x8_t(pub(crate) u16, pub(crate) u16, pub(crate) u16, pub(crate) u16, pub(crate) u16, pub(crate) u16, pub(crate) u16,...
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

error[E0076]: SIMD vector's only field must be an array
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
   --> core/src/../../stdarch/crates/core_arch/src/macros.rs:62:9
    |
52  |  / macro_rules! types {
53  |  |     ($(
54  |  |         $(#[$doc:meta])*
55  |  |         pub struct $name:ident($($fields:tt)*);
...    |
62  |  |         pub struct $name($($fields)*);
63  |  |     )*)
64  |  | }
    |  |_- in this expansion of `types!`
    |
    |
   ::: core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:19:1
    |
19  | /  types! {
20  | |      /// ARM-specific 64-bit wide vector of eight packed `i8`.
21  | |      #[cfg_attr(not(target_arch = "arm"), stable(feature = "neon_intrinsics", since = "1.59.0"))]
22  | |      #[cfg_attr(target_arch = "arm", unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800"))]
...   |
105 | |      pub struct poly16x8_t(pub(crate) p16, pub(crate) p16, pub(crate) p16, pub(crate) p16, pub(crate) p16, pub(crate) p16, pub(crate) p16,...
...   |
...   |
129 | |      pub struct poly64x2_t(pub(crate) p64, pub(crate) p64);
    | |__- in this macro invocation

dvdsk · 2024-10-26T14:19:50Z

@rustbot ready

Is CI broken? I cant get it to pass but the error seems unrelated?

bors · 2024-10-28T19:34:00Z

☔ The latest upstream changes (presumably #132145) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot assigned cuviper Nov 30, 2023

dvdsk marked this pull request as ready for review November 30, 2023 16:03

joboet reviewed Dec 4, 2023

View reviewed changes

library/std/tests/thread.rs Outdated Show resolved Hide resolved

library/std/src/thread/mod.rs Show resolved Hide resolved

dvdsk force-pushed the sleep_until_os_specific_impl branch 2 times, most recently from 7ace020 to 1e36e08 Compare December 24, 2023 14:44

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 24, 2023

This comment has been minimized.

Sign in to view

dvdsk force-pushed the sleep_until_os_specific_impl branch from 5470a7c to a0f50b6 Compare December 24, 2023 16:44

dvdsk marked this pull request as draft December 24, 2023 16:47

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2024

This comment has been minimized.

Sign in to view

dvdsk and others added 19 commits October 26, 2024 12:41

adds specialized impl of sleep_until for unix and wasi

10fb0c7

adds specialized impl for sleep_until for macos/ios/watchos/tvos

eac212a

adds specialized impl for sleep_until for windows

70e0d21

(lib/sleep_until) adds test & update docs & fix mac support

947899e

removes the specialization for windows OS

05f1cad

It is not working and I can not figure out why. Since I am not familiar with developing on windows I might not be the best person to work on this. The work removed in this commit might be a useful jumping off point for anyone else however.

add visionos to sleep_until + check mach_wait_until result

f8850e1

fix missing non specialized windows sleep fn

1f32d20

(lib/sleep_until) use target_vendor apple + fix windows removeal + add

d1ae96a

more unix platforms target_vendor's done by: Co-authored-by: Jonas Böttiger <jonasboettiger@icloud.com>

(lib/sleep_until) allow unused code for Instant::into_inner

5ddda70

(lib/sleep_until) fmt + fix tiny rebase mistake

e95b653

(lib/sleep_until) mac, check for aborted and comment on docs

124a1f5

(lib/sleep_util) fix missing import

840188d

(lib/sleep_until) add vxworks (os) clock_nanosleep impl

7f65a9d

sleep_until: fixes incorrect assert, improves comments to docs with l…

a779c23

…inks Co-authored-by: joboet <jonasboettiger@icloud.com>

fixes test

237923c

try fix assert_eq

47361f7

fix assert macro

314db2a

fix assert macro

801807e

remove assert msg

0a45de6

dvdsk force-pushed the sleep_until_os_specific_impl branch from 2c4f02f to 0a45de6 Compare October 26, 2024 12:21

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Specialize sleep_until implementation #118480

Specialize sleep_until implementation #118480

dvdsk commented Nov 30, 2023 •

edited

Loading

rustbot commented Nov 30, 2023

dvdsk commented Nov 30, 2023

cuviper commented Nov 30, 2023

joboet left a comment

bors commented Dec 7, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Jan 13, 2024

cuviper commented Jan 25, 2024

Dylan-DPC commented Feb 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Oct 26, 2024

rust-log-analyzer commented Oct 26, 2024

dvdsk commented Oct 26, 2024

bors commented Oct 28, 2024

Specialize sleep_until implementation #118480

Are you sure you want to change the base?

Specialize sleep_until implementation #118480

Conversation

dvdsk commented Nov 30, 2023 • edited Loading

rustbot commented Nov 30, 2023

dvdsk commented Nov 30, 2023

cuviper commented Nov 30, 2023

joboet left a comment

Choose a reason for hiding this comment

bors commented Dec 7, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Jan 13, 2024

cuviper commented Jan 25, 2024

Dylan-DPC commented Feb 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Oct 26, 2024

rust-log-analyzer commented Oct 26, 2024

dvdsk commented Oct 26, 2024

bors commented Oct 28, 2024

dvdsk commented Nov 30, 2023 •

edited

Loading