Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] const-stabilize Hash{Map/Set}::new #118423

Closed
wants to merge 2 commits into from
Closed

[WIP] const-stabilize Hash{Map/Set}::new #118423

wants to merge 2 commits into from

Conversation

aDotInTheVoid
Copy link
Member

Like #118416, but without the random compiler changes to debug this.

I want to see if this works on CI before figuring out if the hacks are permissible.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 28, 2023
@aDotInTheVoid aDotInTheVoid marked this pull request as draft November 28, 2023 20:20
@aDotInTheVoid aDotInTheVoid mentioned this pull request Nov 28, 2023
Closed
3 tasks
@aDotInTheVoid
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 28, 2023

⌛ Trying commit 139dd27 with merge 538cd1e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2023
@bors
Auto merge of rust-lang#118423 - aDotInTheVoid:const-stabilize-2, r=<…
538cd1e 
…try>

 [WIP] const-stabilize Hash{Map/Set}::new

Like rust-lang#118416, but without the random compiler changes to debug this.

I want to see if this works on CI before figuring out if the hacks are permissible.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Nov 28, 2023

☀️ Try build successful - checks-actions
Build commit: 538cd1e (538cd1ec69091573e7646db971ad7777984efccf)

@aDotInTheVoid
Copy link
Member Author

Superceeded by #118427, which does it with sensible commit seperation (and tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aDotInTheVoid @bors @rustbot