expost Path::sep{,_byte} #11642
Merged
expost Path::sep{,_byte} #11642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. Thanks. |
| @@ -117,6 +117,20 @@ pub use StrComponentIter = self::windows::StrComponentIter; | |||
| #[cfg(windows)] | |||
| pub use RevStrComponentIter = self::windows::RevStrComponentIter; | |||
|
|
|||
| /// Typedef for the platform-native separator character. | |||
| #[cfg(unix)] | |||
| pub use sep = self::posix::sep; | |||
There was a problem hiding this comment.
Stylistically, shouldn't these be SEP and SEP_BYTE?
There was a problem hiding this comment.
Hrm, possibly. We've been exposing std::path::posix::sep and std::path::windows::sep already. I have no objection to capitalizing them though.
There was a problem hiding this comment.
@huonw: good point, capitalizing them now.
There was a problem hiding this comment.
(Also, it's not a "typedef" so much as an alias.)
|
r=me after fixing the doc comment nit. |
bors
added a commit
that referenced
this pull request
Jan 19, 2014
This pull request exposes a platform independent way to get the path separator. This is useful when building complicated paths by hand.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 11, 2024
improve [`cast_sign_loss`], to skip warning on always positive expressions fixes: rust-lang#11642 changelog: improve [`cast_sign_loss`] to skip warning on always positive expressions Turns out this is change became quite big, and I still can't cover all the cases, like method calls such as `POSITIVE_NUM.mul(POSITIVE_NUM)`, or `NEGATIVE_NUM.div(NEGATIVE_NUM)`... but well, if I do, I'm scared that this will goes forever, so I stopped, unless it needs to be done, lol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request exposes a platform independent way to get the path separator. This is useful when building complicated paths by hand.