-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point at cause of expectation of break
value when possible
#116071
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
pls fix typo, r=me |
f803e45
to
dfc4a3d
Compare
I added another mechanism to check for when the typeck inference comes from other |
bae2b8f
to
d3dea30
Compare
Actually, I'll just open another PR. @bors r=compiler-errors |
☀️ Test successful - checks-actions |
Finished benchmarking commit (136d74f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 635.361s -> 633.587s (-0.28%) |
…errors Point at more causes of expectation of break value when possible Follow up to rust-lang#116071. r? `@compiler-errors` Disregard the first commit, which is in the other PR.
When encountering a type error within the value of a
break
statement, climb the HIR tree to identify if the expectation comes from an assignment or a return type (if the loop is the tail expression of afn
).Fix #115905.