Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for --cap-lints allow and trait bounds warning #114164

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Jul 28, 2023

Closes #43134

I have verified that the test fails if stderr begins to contain output by making sure the test fails when I add

eprintln!("some output on stderr");

to the compiler (I added it to fn build_session()).

@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 28, 2023
@Enselic Enselic changed the title Add regresssion test for --cap-lints allow and trait bounds warning Add regression test for --cap-lints allow and trait bounds warning Jul 28, 2023
I have verified that the test fails if stderr begins to contain output
by making sure the test fails when I add

    eprintln!("some output on stderr");

to the compiler (I added it to `fn build_session()`).
@Enselic Enselic force-pushed the lint-cap-trait-bounds branch from 05a68f1 to 38e0d58 Compare July 28, 2023 09:11
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 28, 2023

📌 Commit 38e0d58 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114099 (privacy: no nominal visibility for assoc fns )
 - rust-lang#114128 (When flushing delayed span bugs, write to the ICE dump file even if it doesn't exist)
 - rust-lang#114138 (Adjust spans correctly for fn -> method suggestion)
 - rust-lang#114146 (Skip reporting item name when checking RPITIT GAT's associated type bounds hold)
 - rust-lang#114147 (Insert RPITITs that were shadowed by missing ADTs that resolve to [type error])
 - rust-lang#114155 (Replace a lazy `RefCell<Option<T>>` with `OnceCell<T>`)
 - rust-lang#114164 (Add regression test for `--cap-lints allow` and trait bounds warning)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a4b9405 into rust-lang:master Jul 29, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 29, 2023
@Enselic Enselic deleted the lint-cap-trait-bounds branch August 17, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning shown despite --cap-lints=allow: E0122 "trait bounds are not (yet) enforced in type definitions"
4 participants