[Experiment] Crater run with -Ztrait-solver=next-coherence
#113895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors try |
|
(cc @lcnr) |
|
⌛ Trying commit 8d2046922c4b4a4f159120ab5e4fcbdb33777505 with merge 679467dda60caf04032ce789aebd47bb6325618c... |
|
☀️ Try build successful - checks-actions |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
lcnr
reviewed
Jul 21, 2023
|
@craterbot cancel |
|
🚨 Error: failed to parse the command 🆘 If you have any trouble with Crater please ping |
|
@craterbot abort |
|
🗑️ Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
14 tasks
8d20469 to
e82dcc0
Compare
|
@bors try |
|
⌛ Trying commit e82dcc0 with merge c008da7c8a7598ce071579d1130c66d76e43a4b1... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
@bors try |
|
⌛ Trying commit 6508c9b with merge 2e32e486ee7945e4b905ff82d6bf81ef77d60daa... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☀️ Try build successful - checks-actions |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
|
@craterbot run mode=check-only crates=https://crater-reports.s3.amazonaws.com/pr-113895/retry-regressed-list.txt |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
|
Filed one bug having to do with the difference in the way that trait solvers treat inductive cycles: rust-lang/trait-system-refactor-initiative#50 Minimized another from async-lazy: use std::future::Future;
use std::marker::PhantomData;
use std::pin::Pin;
pub(crate) struct Lazy<T, Fut = Pin<Box<dyn Future<Output = T> + Send>>> {
_fut: PhantomData<Fut>,
_t: PhantomData<T>,
}
impl<'a, T, Fut> std::future::IntoFuture for Pin<&'a mut Lazy<T, Fut>>
where
Fut: Future<Output = T>,
{
type Output = Pin<&'a mut T>;
type IntoFuture = Pin<Box<dyn Future<Output = Pin<&'a mut T>> + Send>>;
fn into_future(self) -> Self::IntoFuture {
todo!()
}
}That one fails because we don't treat this goal |
|
while we're at it @rust-timer build 679467dda60caf04032ce789aebd47bb6325618c |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (679467dda60caf04032ce789aebd47bb6325618c): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.008s -> 648.881s (-0.17%) |
|
Another failure: rust-lang/trait-system-refactor-initiative#52 |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yeet
r? @ghost