Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustc_llvm from llvm-stamp nags #113543

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Remove rustc_llvm from llvm-stamp nags #113543

merged 1 commit into from
Jul 11, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jul 10, 2023

LLVM is not built by compiler/rustc_llvm at all, only bindings on
top of it, so there's no need to bump download-ci-llvm-stamp for that.

@cuviper
Remove rustc_llvm from llvm-stamp nags
68a381f 
LLVM is not *built* by `compiler/rustc_llvm` at all, only bindings on
top of it, so there's no need to bump `download-ci-llvm-stamp` for that.
@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023
@jyn514
Copy link
Member

jyn514 commented Jul 10, 2023

ah, i see that rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz doesn't include rustc_llvm at all, only LLVM itself. ok, this seems good :)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 10, 2023

📌 Commit 68a381f has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 11, 2023
@bors
Auto merge of rust-lang#113559 - matthiaskrgr:rollup-jrqyctc, r=matth…
fcaf04e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#113386 (style-guide: Expand example of combinable expressions to include arrays)
 - rust-lang#113523 (Reuse LLVMConstInBoundsGEP2)
 - rust-lang#113528 (Dynamically size sigaltstk in rustc)
 - rust-lang#113543 (Remove `rustc_llvm` from llvm-stamp nags)
 - rust-lang#113548 (Update books)
 - rust-lang#113551 (bootstrap: Don't print "Skipping" twice)
 - rust-lang#113556 (Don't use serde-derive in the rls shim)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c2d4af6 into rust-lang:master Jul 11, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 11, 2023
@cuviper cuviper deleted the triagebot-llvm branch July 27, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @rustbot @jyn514 @bors @Mark-Simulacrum