Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[watchos] Fix broken target arm64_32-apple-watchos #111267

Closed
wants to merge 1 commit into from

Conversation

vladimir-ea
Copy link
Contributor

Issue #111217

@rustbot
Copy link
Collaborator

rustbot commented May 5, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 5, 2023
@workingjubilee
Copy link
Member

Are we sure that this is the right fix? To my understanding, watchOS is an AArch64-ILP32 target. The PR adding it to LLVM certainly thinks so.

@vladimir-ea
Copy link
Contributor Author

The 'proper' fix is here: gimli-rs/object#542.

This is a workaround to revert to the previous behaviour, but I guess the previous behaviour was wrong, although it did 'work' (in the sense that it was possible to build and run rust libraries for arm64_32-apple-watchos).

Mybe I should close this Pr and wait for the 'object' change?

@workingjubilee
Copy link
Member

I don't think it would be invalid to choose to revert to the previous behavior. Partly because it's not required that the target work, so switching from busted (doesn't compile) to busted (compiles at all, but might miscompile a random program) is permitted, strictly speaking.

This does imply there's also no mandate to get this target up and running immediately, and we know that both behaviors we can choose from without updating object are incorrect. What you just said suggests to me your inclination is in fact to wait for the object fix. So I would encourage you to follow your inclination.

Which also means that if you do want to land this, then as far as I am concerned, by all means.

@compiler-errors
Copy link
Member

Not sure if I have a strong opinion about this, so

r? @workingjubilee

@vladimir-ea
Copy link
Contributor Author

Closing this since the fix to 'object' has been released. See: #111413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants