Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused ftl messages #110597

Merged
merged 2 commits into from
Apr 21, 2023
Merged

remove unused ftl messages #110597

merged 2 commits into from
Apr 21, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Apr 20, 2023

r? @davidtwco

does it make sense to check via tidy that there exist no ftl message names which are never mentioned in compiler/**.rs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2023
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 20, 2023

📌 Commit 82cb8a2 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned davidtwco Apr 20, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2023
@bors
Auto merge of rust-lang#110636 - matthiaskrgr:rollup-faa33c6, r=matth…
b92a41c 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110365 (ship tools with sysroot)
 - rust-lang#110555 (Substitute missing trait items suggestion correctly)
 - rust-lang#110578 (fix(error): normalize whitespace during msg_to_buffer)
 - rust-lang#110597 (remove unused ftl messages)
 - rust-lang#110611 (Add regression test for rust-lang#46506)
 - rust-lang#110618 (Track if EvalCtxt has been tainted, make sure it can't be used to make query responses after)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a8e2394 into rust-lang:master Apr 21, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 21, 2023
@lcnr lcnr deleted the not-pin-via-negative-bound branch April 21, 2023 08:24
@davidtwco davidtwco mentioned this pull request Apr 24, 2023
Open
@davidtwco
Copy link
Member

does it make sense to check via tidy that there exist no ftl message names which are never mentioned in compiler/**.rs

It does, I've opened #110754 to track that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @compiler-errors @bors @davidtwco @rustbot