-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cargo #103860
Update cargo #103860
Conversation
Some changes occurred in src/tools/cargo cc @ehuss |
I believe this is an update that will become beta in less than 3 days. Could you double-check that all go well? Thanks! |
Beta already branched last week, so this will be in 1.67. The process is documented at https://forge.rust-lang.org/release/process.html, but in summary:
So, if you want something to get in to the next beta, it needs to land before the Friday before the release. @bors r+ p=1 |
📌 Commit 8e38f06d8af16435944d2efe73fc1e6723077d4c has been approved by It is now in the queue for this repository. |
⌛ Testing commit 8e38f06d8af16435944d2efe73fc1e6723077d4c with merge 36d154b38847d9e08f5cb956a5402d219a50287b... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
14 commits in 7e484fc1a766f56dbc95380f45719698e0c82749..810cbad9a123ad4ee0a55a96171b8f8478ff1c03 2022-10-27 15:20:57 +0000 to 2022-11-02 21:04:31 +0000 - Update curl-sys (rust-lang/cargo#11326) - Mention fix on build script deadlock (rust-lang/cargo#11325) - Make cargo forward pre-existing CARGO if set (rust-lang/cargo#11285) - Clean up workspace dependencies after cargo remove (rust-lang/cargo#11242) - Update the outdated link for rust-semverver (rust-lang/cargo#11322) - Fix broken link to compilation entry point (rust-lang/cargo#11317) - Only remove fingerprints and build script artifacts of the requested package (rust-lang/cargo#10621) - Newer anyhow features are required (rust-lang/cargo#11316) - Clean stale git temp files (rust-lang/cargo#11308) - Report crate size on package and publish (rust-lang/cargo#11270) - add a note that some warnings (and/or errors) can be auto-fixed (rust-lang/cargo#10989) - Update libcurl (rust-lang/cargo#11307) - artifact deps shoud works when target field specified coexists with `optional = true` (rust-lang/cargo#11183) - Fix singular verb in tests page (rust-lang/cargo#11300)
8e38f06
to
331aa45
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (432b1a4): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Warning ⚠: The following benchmark(s) failed to build:
cc @rust-lang/wg-compiler-performance Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Does this require e.g. changing installed native libraries on the perf machine for the cargo and rustc benchmarks to keep working ? (Don't worry about the perf regression it's just noise of course.) @rustbot label: +perf-regression-triaged |
Investigation in https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/cargo.20and.20rustc.20benchmarks.20broken seems to show this introducing a Cargo bug, so I'm going to post a revert for this PR until we have a further diagnosis. Will also file a Cargo issue shortly. |
…-Simulacrum Revert "Update cargo" This reverts commit 331aa45. This Cargo upgrade introduced a regression into dependency resolution, so reverting the upgrade until we can fix that. cc rust-lang#103860, https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/cargo.20and.20rustc.20benchmarks.20broken
14 commits in 7e484fc1a766f56dbc95380f45719698e0c82749..810cbad9a123ad4ee0a55a96171b8f8478ff1c03
2022-10-27 15:20:57 +0000 to 2022-11-02 21:04:31 +0000
optional = true
(artifact deps should work when target field specified coexists withoptional = true
cargo#11183)r? @ghost