Update Android target to use new build system integration #102756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Android build support relies on standalone toolchains which are obsolete as of NDK r19. This change adds support for the new build system integration described here: https://developer.android.com/ndk/guides/other_build_systems This avoids developers needing to create a standalone toolchain for each target as well as needing to specify the NDK path on each target, as the NDK path is now specified via [build]. The target-specific android-ndk option is still available for users of standalone toolchains.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
|
☔ The latest upstream changes (presumably #102332) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This was already done in #102332 to my understanding. |
|
The main missing piece from that PR was a cleanup of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Android build support relies on standalone toolchains which are obsolete as of NDK r19. This change adds support for the new build system integration described here:
https://developer.android.com/ndk/guides/other_build_systems
This avoids developers needing to create a standalone toolchain for each target as well as needing to specify the NDK path on each target, as the NDK path is now specified via [build]. The target-specific android-ndk option is still available for users of standalone toolchains.