Add powerpc-unknown-linux-muslspe compile target #100860
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. |
|
This comment has been minimized.
This comment has been minimized.
cca6238 to
c891c9b
Compare
There was a problem hiding this comment.
In order for the new documentation file to be picked up, it needs to be added to SUMMARY.md.
|
r? compiler-team |
c891c9b to
3f546c5
Compare
This comment has been minimized.
This comment has been minimized.
3cfd0e1 to
c069457
Compare
This comment has been minimized.
This comment has been minimized.
c069457 to
9631a31
Compare
This comment has been minimized.
This comment has been minimized.
9631a31 to
bb3d1a6
Compare
|
Please quote the corresponding requirements verbatim from the tier 3 target tier policy to explain how the target meets those requirements (leaving a new comment here is fine). You can find an example of this in the PR description for #86191. Thank you! |
This is almost identical to already existing targets: - powerpc_unknown_linux_musl.rs - powerpc_unknown_linux_gnuspe.rs It has support for PowerPC SPE (muslspe), which can be used with GCC version up to 8. It is useful for Freescale or IBM cores like e500. This was verified to be working with OpenWrt build system for CZ.NIC's Turris 1.x routers, which are using Freescale P2020, e500v2, so add it as a Tier 3 target.
bb3d1a6 to
3955e8e
Compare
|
Switching to waiting on author to incorporate changes suggested in this comment. Feel free to request a review with @rustbot author |
|
Hi @BKPepe! Specifically, we're looking for you to leave a comment like this one, copying and replying to the tier 3 target policy. Thanks! |
|
☔ The latest upstream changes (presumably #104743) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@BKPepe FYI: when a PR is ready for review, send a message containing |
|
I'm going to close this for now since we haven't heard back in a while. Feel free to re-open the PR if you have more time in the future (make sure to re-open before pushing to the branch; due to a quirk of github you'll have to make a new PR otherwise). |
|
It looks I will need to create a new PR, because I can not re-open this one. |
Add powerpc-unknown-linux-muslspe compile target This is almost identical to already existing targets: - powerpc_unknown_linux_musl.rs - powerpc_unknown_linux_gnuspe.rs It has support for PowerPC SPE (muslspe), which can be used with GCC version up to 8. It is useful for Freescale or IBM cores like e500. This was verified to be working with OpenWrt build system for CZ.NIC's Turris 1.x routers, which are using Freescale P2020, e500v2, so add it as a Tier 3 target. Follow-up of rust-lang#100860
Rollup merge of rust-lang#127905 - BKPepe:powerpc-muslspe, r=wesleywiser Add powerpc-unknown-linux-muslspe compile target This is almost identical to already existing targets: - powerpc_unknown_linux_musl.rs - powerpc_unknown_linux_gnuspe.rs It has support for PowerPC SPE (muslspe), which can be used with GCC version up to 8. It is useful for Freescale or IBM cores like e500. This was verified to be working with OpenWrt build system for CZ.NIC's Turris 1.x routers, which are using Freescale P2020, e500v2, so add it as a Tier 3 target. Follow-up of rust-lang#100860
This is almost identical to already existing targets:
Unfortunately, I could not find documentation for these targets in
src/doc/rustc/src/platform-support.It has support for PowerPC SPE (muslspe), which
can be used with GCC version up to 8. It is useful for Freescale or IBM
cores like e500.
This was verified to be working with OpenWrt build system for CZ.NIC's
Turris 1.x routers, which are using Freescale P2020, e500v2, so add it as
a Tier 3 target.