Box the MacCall in various types.

[nnethercote]

r? @spastorino

[nnethercote]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 1f3cc4c5bbec05d41b2778f41797c62f8349f262 with merge 8cfb9ad092a50c6cf686d19bfe5682e7bfcae039...

[bors]

☀️ Try build successful - checks-actions
Build commit: 8cfb9ad092a50c6cf686d19bfe5682e7bfcae039 (8cfb9ad092a50c6cf686d19bfe5682e7bfcae039)

[rust-timer]

Queued 8cfb9ad092a50c6cf686d19bfe5682e7bfcae039 with parent 80ed61f, future comparison URL.

[rust-timer]

Finished benchmarking commit (8cfb9ad092a50c6cf686d19bfe5682e7bfcae039): comparison url.

Instruction count

• Primary benchmarks: ❌ relevant regression found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions ❌ (primary)	0.8%	0.8%	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	0.8%	1

Max RSS (memory usage)

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: ❌ relevant regression found

	mean1	max	count2
Regressions ❌ (primary)	1.6%	2.1%	4
Regressions ❌ (secondary)	1.8%	1.8%	1
Improvements ✅ (primary)	-0.5%	-0.5%	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	2.1%	5

Cycles

Results

• Primary benchmarks: ✅ relevant improvement found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.9%	5.9%	1
Improvements ✅ (primary)	-3.1%	-3.1%	1
Improvements ✅ (secondary)	-1.8%	-1.8%	1
All ❌✅ (primary)	-3.1%	-3.1%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[spastorino]

@nnethercote by looking at the changes it did look good to me but by looking at perf results I'm not sure what were you expecting to see but on primary and secondary benchmarks doesn't seem to be big wins. Although I see some moderate improvements on bootstrapping.

Anyway, what are your thoughts Nick?.

[nnethercote]

It's performance neutral at the moment. There are two reasons I want to merge this. First, we just tend to box larger structs in the AST anyway. Second, Expr is the by far the most important AST type, instantiated the most, and while this change alone isn't enough to shrink it, it is necessary, because MacCall is one of several equally large ExprKind variants.

[nnethercote]

Also, Ty is pretty important and this is step one (of 2) for shrinking it from 96 bytes to 64 bytes.

[nnethercote]

I rebased to fix the conflicts.

[bors]

☔ The latest upstream changes (presumably #100441) made this pull request unmergeable. Please resolve the merge conflicts.

[spastorino]

ohh merge conflicts again, r=me after you fix those.

[nnethercote]

I fixed the conflicts.

@bors r=spastorino

[bors]

📌 Commit eafd0df has been approved by spastorino

It is now in the queue for this repository.

[bors]

⌛ Testing commit eafd0df with merge 11edee4ef66f16853d0ee0ab305cb9f82848b70e...

[bors]

💥 Test timed out

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[spastorino]

@bors retry

[bors]

⌛ Testing commit eafd0df with merge dd01122...

[bors]

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing dd01122 to master...

[rust-timer]

Finished benchmarking commit (dd01122): comparison url.

Instruction count

• Primary benchmarks: ❌ relevant regression found
• Secondary benchmarks: ❌ relevant regression found

	mean1	max	count2
Regressions ❌ (primary)	0.9%	0.9%	1
Regressions ❌ (secondary)	0.4%	0.4%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	0.9%	1

Max RSS (memory usage)

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	1.5%	1.6%	2
Regressions ❌ (secondary)	1.8%	1.9%	3
Improvements ✅ (primary)	-3.2%	-3.4%	2
Improvements ✅ (secondary)	-2.5%	-2.5%	1
All ❌✅ (primary)	-0.8%	-3.4%	4

Cycles

Results

• Primary benchmarks: ✅ relevant improvement found
• Secondary benchmarks: ✅ relevant improvement found

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.1%	-3.1%	1
Improvements ✅ (secondary)	-2.7%	-2.7%	1
All ❌✅ (primary)	-3.1%	-3.1%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³