Make the GATS self outlives error take into GATs in the inputs #100382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Sorry for taking so long to review this @jackh726 -- do you want to discuss this on Monday, or are you reasonably confident that this is the right step? Happy to r+ if it's the latter. |
|
@bors r+ |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 23, 2022
…r=compiler-errors
Make the GATS self outlives error take into GATs in the inputs
Before, the reasoning was that outlives should factor in to the outlives error, because that value is produced and inputs aren't. However, this is potentially confusing, and we can just require this for now and relax it later if we need. GATs in where clauses still don't count for the self outlives error, and I've added a test for that.
This now errors:
```rust
trait Input {
type Item<'a>;
//~^ missing required
fn takes_item<'a>(&'a self, item: Self::Item<'a>);
}
```
I've also added a test that this does not:
```rust
trait WhereClause {
type Item<'a>;
fn takes_item<'a>(&'a self) where Self::Item<'a>: ;
}
```
r? `@compiler-errors`
This was referenced Aug 23, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#100382 (Make the GATS self outlives error take into GATs in the inputs) - rust-lang#100565 (Suggest adding a missing semicolon before an item) - rust-lang#100641 (Add the armv4t-none-eabi target to the supported_targets) - rust-lang#100789 (Use separate infcx to solve obligations during negative coherence) - rust-lang#100832 (Some small bootstrap cleanup) - rust-lang#100861 (fix ICE with extra-const-ub-checks) - rust-lang#100862 (tidy: remove crossbeam-utils) - rust-lang#100887 (Refactor part of codegen_call_terminator) - rust-lang#100893 (Remove out-of-context comment in `mem::MaybeUninit` documentation) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the reasoning was that outlives should factor in to the outlives error, because that value is produced and inputs aren't. However, this is potentially confusing, and we can just require this for now and relax it later if we need. GATs in where clauses still don't count for the self outlives error, and I've added a test for that.
This now errors:
I've also added a test that this does not:
r? @compiler-errors