Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move x test --skip to be part of --exclude #100004

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Move x test --skip to be part of --exclude #100004

merged 1 commit into from
Aug 7, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 31, 2022

--skip is inconsistent with the rest of the interface and redundant with --exclude.
Fix --exclude to work properly for files and directories rather than having a separate flag.

Fixes #96342. cc #96493 (comment)

r? @Mark-Simulacrum

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 31, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2022
@jyn514 jyn514 marked this pull request as ready for review July 31, 2022 23:27
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jul 31, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514
Move x test --skip to be part of --exclude
f8ed52f 
`--skip` is inconsistent with the rest of the interface and redundant with `--exclude`.
Fix --exclude to work properly for files and directories rather than having a separate flag.

If someone needs to use --skip for something other than compiletest,
they can use `--test-args --skip` instead.
@jyn514 jyn514 force-pushed the exclude-single-test branch from 5cd058c to f8ed52f Compare July 31, 2022 23:59
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 6, 2022

📌 Commit f8ed52f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2022
@bors
Copy link
Contributor

bors commented Aug 7, 2022

⌛ Testing commit f8ed52f with merge 24cf45a...

@bors
Copy link
Contributor

bors commented Aug 7, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 24cf45a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2022
@bors bors merged commit 24cf45a into rust-lang:master Aug 7, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 7, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (24cf45a): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 1.7% 1.8% 4
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 5.3% 5.3% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.8% -2.8% 1
All 😿🎉 (primary) 5.3% 5.3% 1

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.2% 3.2% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@jyn514 jyn514 deleted the exclude-single-test branch August 7, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

--exclude is broken for individual files
7 participants
@jyn514 @rust-log-analyzer @Mark-Simulacrum @bors @rust-timer @rust-highfive @rustbot