Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc-json: Rename implementors to implementations #94198

Closed
aDotInTheVoid opened this issue Feb 20, 2022 · 0 comments · Fixed by #94921
Closed

rustdoc-json: Rename implementors to implementations #94198

aDotInTheVoid opened this issue Feb 20, 2022 · 0 comments · Fixed by #94921
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@aDotInTheVoid
Copy link
Member

aDotInTheVoid commented Feb 20, 2022 •
edited
Loading

The ID's in Trait's implementors field are those for impl Trait for Type, not Type

Eg:

pub trait Debug {}

impl Debug for u8 {}
"0:3": {
      "inner": {
        "implementors": ["0:4"],
        "items": []
      },
      "kind": "trait",
      "name": "Debug",
  }
    "0:4": {
      "id": "0:4",
      "inner": {
        "blanket_impl": null,
        "for": {"inner": "u8", "kind": "primitive"},
        "items": [],
        "trait": {
          "inner": {
            "args": {"angle_bracketed": {"args": [], "bindings": []}},
            "id": "0:3",
            "name": "Debug",
            "param_names": []
          },
          "kind": "resolved_path"
        }
      },
      "kind": "impl",
      "links": {},
      "name": null,
      "span": {"begin": [15, 0], "end": [15, 20], "filename": "blanket.rs"},
      "visibility": "crate"
    },

@rustbot modify labels: +T-rustdoc +A-rustdoc-json
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 20, 2022
@aDotInTheVoid aDotInTheVoid mentioned this issue Mar 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 14, 2022
@bors
Auto merge of rust-lang#94921 - aDotInTheVoid:rustdoc-json-format-cle…
6b9b2bd 
…anup, r=CraftSpider

rustdoc-json: Clean Up json format

No semantic changes, but better names

Closes rust-lang#94198

Closes rust-lang#94889

r? `@CraftSpider`

`@rustbot` modify labels: +A-rustdoc-json +T-rustdoc +C-cleanup
@bors bors closed this as completed in a5c0b14 Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc-json: Clean Up json format aDotInTheVoid/rust
2 participants
@aDotInTheVoid @rustbot