-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: stabilized (added) versions of enum variants are hard to read #86342
Comments
I am new here but it looks like something I could do. |
Sorry but I'm not familiar with rustdoc, @jyn514 could you help them? |
I don't have time, sorry. @GuillaumeGomez may have suggestions. |
I can help if needed. But first: how would you want it to look like? |
As mentioned first, the version at the same height should be the variant's IMO. |
Ah ok sorry, so it's a layout bug. I thought you wanted to improve the display (which would be welcome too!). The problematic line is this one. It should be set before the docblock (in the variant header if possible). |
I will gladly take a look at it, so I can familiarize with the codebase. |
Sure, go ahead! Do test locally:
Like that you can then go to the page and check if the bug is fixed. ;) |
…d-versions-layout, r=GuillaumeGomez Fix rustdoc stabilized versions layout Fixes rust-lang#86342 r? ``@GuillaumeGomez``
Go to: https://doc.rust-lang.org/nightly/std/io/enum.ErrorKind.html#variant.OutOfMemory
It was stabilized (i.e. added) in 1.54.0 but the rustdoc generates like:
The problem is that the previous variant's version is placed at the same height. I think it's ideal to place the version of the item itself at the same height, like functions.
The text was updated successfully, but these errors were encountered: