Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra::stats::write_boxplot takes positive sample values only #8451

Closed
dmanescu opened this issue Aug 11, 2013 · 0 comments
Closed

extra::stats::write_boxplot takes positive sample values only #8451

dmanescu opened this issue Aug 11, 2013 · 0 comments

Comments

@dmanescu
Copy link
Contributor

The program

extern mod extra;

use extra::stats;

fn main() {
    let s = stats::Summary::new([0.0, 2.0, 3.0]);
    stats::write_boxplot(std::io::stdout(), &s, 100) 
}

outputs

NaN |[#]                                                                                          | 3

because the choice of upper and lower limits of the boxplot involves log10().
@bors bors closed this as completed in 767688f Aug 14, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 24, 2022
@bors
Auto merge of rust-lang#8451 - matthiaskrgr:ui_speedup, r=llogiq
7f8760a 
tests: default to more threads for ui-tests

Benchmarks (tested on i5-7200U, 2 cores, 4 threads)

```
master branch:

cargo test // prime caches
cargo --color=always test  70,39s user 21,91s system 180% cpu 51,035 total
cargo --color=always test  70,77s user 22,13s system 180% cpu 51,579 total
cargo --color=always test  70,97s user 22,12s system 180% cpu 51,673 total

cargo --color=always nextest run  78,74s user 22,27s system 220% cpu 45,829 total
cargo --color=always nextest run  78,46s user 21,92s system 224% cpu 44,674 total
cargo --color=always nextest run  78,31s user 22,21s system 228% cpu 43,909 total

Patched (ui_speedup branch):

cargo test // prime cache
cargo --color=always test  97,51s user 32,02s system 288% cpu 44,905 total
cargo --color=always test  99,19s user 31,91s system 276% cpu 47,436 total
cargo --color=always test  98,47s user 31,84s system 284% cpu 45,744 total

cargo --color=always nextest run  102,18s user 30,80s system 350% cpu 37,902 total
cargo --color=always nextest run  99,75s user 29,86s system 350% cpu 36,935 total
cargo --color=always nextest run  100,36s user 29,93s system 351% cpu 37,061 total
```

changelog: use more threads for running clippys ui-tests for ~10% walltime speedup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmanescu