Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM shouldn't be build with --disable-threads #7071

Closed
alexcrichton opened this issue Jun 11, 2013 · 3 comments · Fixed by #7393
Closed

LLVM shouldn't be build with --disable-threads #7071

alexcrichton opened this issue Jun 11, 2013 · 3 comments · Fixed by #7393
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.

Comments

@alexcrichton
Copy link
Member

After #6511 and #7040, rustc is ready to use LLVM completely threadsafely.

All that's missing is to stop passing the --disable-threads and --disable-pthreads flags to LLVM's configure script. Once this is done, the lock-enabling code in trans should be uncommented as well.

This is a simple change, but requires the bots to rebuild LLVM (which has caused problems in the past). @brson has some other LLVM patches to integrate, and this would fit nicely with those.
@alexcrichton alexcrichton mentioned this issue Jun 11, 2013
Closed
@catamorphism
Copy link
Contributor

#6511 and #7040 are closed now, so this should be ready to be closed as well. I'm not sure what the problems are with the bots rebuilding LLVM (@brson?) so I'm a bit hesitant to try it myself.

I'd like this to be fixed so I can re-enable the rustpkg tests, though.

@alexcrichton alexcrichton mentioned this issue Jun 26, 2013
Merged
@alexcrichton
Copy link
Member Author

@catamorphism, I just opened a pull request (#7393) to actually stop passing this option to configuring LLVM.

The problem is that this doesn't trigger an LLVM rebuild, so once the change has gone through the bots need to have their llvm checkout cleaned before landing the further improvements (uncommenting that block of code to enable a threadsafe rustc)

@alexcrichton alexcrichton reopened this Jun 26, 2013
catamorphism added a commit to catamorphism/rust that referenced this issue Jun 26, 2013
@catamorphism
rustpkg: Implement RUST_PATH
211d70e 
Unfortunately, the main test for this is ignored due to rust-lang#7071.

Closes rust-lang#5682
@catamorphism catamorphism mentioned this issue Jun 26, 2013
Closed
@brson
Copy link
Contributor

brson commented Jun 26, 2013

We can try running the bots with clean-llvm after that patch lands, but I don't know if it works. Without graydon I think we can at least manually clean the windows, mac, and bsd bots.

@bors bors closed this as completed in ebed4d0 Jun 26, 2013
catamorphism added a commit to catamorphism/rust that referenced this issue Jun 28, 2013
@catamorphism
rustpkg: Implement RUST_PATH
ea62fd1 
Unfortunately, the main test for this is ignored due to rust-lang#7071.

Closes rust-lang#5682
bors added a commit that referenced this issue Jun 28, 2013
@bors
auto merge of #7397 : catamorphism/rust/rustpkg_path, r=catamorphism
887ae82 
r? @brson Unfortunately, the main test for this is ignored due to #7071.

Closes #5682
xFrednet pushed a commit to xFrednet/rust that referenced this issue May 21, 2022
@bors
Auto merge of rust-lang#8699 - Jarcho:vec_init_then_push_7071, r=dswi…
6ec7359 
…j,xFrednet

Don't lint `vec_init_then_push` when further extended

fixes rust-lang#7071

This will still lint when a larger number of pushes are done (four currently). The exact number could be debated, but this is more readable then a sequence of pushes so it shouldn't be too large.

changelog: Don't lint `vec_init_then_push` when further extended.
changelog: Remove `mut` binding from `vec_init_then_push` when possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop passing --disable-threads to LLVM alexcrichton/rust
3 participants
@alexcrichton @brson @catamorphism