extern crate ... as std overrides the injected crate on 2018 edition
#61019
Assignees
Labels
A-HIR
Area: The high-level intermediate representation (HIR)
A-resolve
Area: Name/path resolution done by `rustc_resolve` specifically
C-bug
Category: This is a bug.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
Comments
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 7, 2019
…etrochenkov
Use hygiene for AST passes
AST passes are now able to have resolve consider their expansions as if they were opaque macros defined either in some module in the current crate, or a fake empty module with `#[no_implicit_prelude]`.
* Add an ExpnKind for AST passes.
* Remove gensyms in AST passes.
* Remove gensyms in`#[test]`, `#[bench]` and `#[test_case]`.
* Allow opaque macros to define tests.
* Move tests for unit tests to their own directory.
* Remove `Ident::{gensym, is_gensymed}` - `Ident::gensym_if_underscore` still exists.
cc rust-lang#60869, rust-lang#61019
r? @petrochenkov
|
This would be fixed by #60607. |
|
Opened #75145 which fixes this. |
davidtwco
added a commit
to davidtwco/rust
that referenced
this issue
Aug 16, 2020
This commit adds a test for rust-lang#61019 where a extern crate is imported as `std` which results in name resolution to fail due to the uses of `std` types introduced from lowering. Signed-off-by: David Wood <david@davidtw.co>
davidtwco
added a commit
to davidtwco/rust
that referenced
this issue
Aug 16, 2020
This commit introduces `QPath::LangItem` to the HIR and uses it in AST lowering instead of constructing a `hir::Path` from a slice of symbols. This might be better for performance, but is also much cleaner as the previous approach is fragile. In addition, it resolves a bug (rust-lang#61019) where an extern crate imported as "std" would result in the paths created during AST lowering being resolved incorrectly (or not at all). Co-authored-by: Matthew Jasper <mjjasper1@gmail.com> Signed-off-by: David Wood <david@davidtw.co>
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Aug 16, 2020
…efid-for-lang-items, r=petrochenkov Preallocate `DefId`s for lang items Fixes rust-lang#60607 and fixes rust-lang#61019. This PR introduces `QPath::LangItem` to the HIR and uses it in AST lowering instead of constructing a `hir::Path` from a slice of symbols: - Credit for much of this work goes to @matthewjasper, I basically just [rebased their earlier work](matthewjasper@a227c70#diff-c0f791ead38d2d02916faaad0f56f41d). - Changes to Clippy might not be correct, they compile but attempting to run tests through `./x.py` produced failures which appeared spurious, so I didn't run any clippy tests. - Changes to save analysis might not be correct - tests pass but I don't have a lot of confidence in those changes being correct. - I've used `GenericBounds::LangItemTrait` rather than changing `PolyTraitRef`, as suggested by @matthewjasper [in this comment](matthewjasper@a227c70#r40107992) but I'd prefer that be left for a follow-up. - I've split things into smaller commits fairly arbitrarily to make the diff easier to review, each commit should compile but might not pass tests until the final commit. r? @oli-obk cc @matthewjasper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On the 2018 edition the following code:
will:
Try to resolveprelude::v1::*insome_crate, failing if it doesn't exist. This probably limits the plausible cases where this could happen toextern crate core as std, andextern crate core as stdwith#![no_std].some_crateinany built-in derives and forHIR lowering.I would expect that the prelude and derives/HIR lowering to always use the injected std/core. Paths starting with
stdshould still resolve to the in the crate the user provided.In the 2015 edition it creates a name conflict with the implicit
extern crate std.cc @petrochenkov @eddyb
The text was updated successfully, but these errors were encountered: