Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy: Enforce that groups in declare_feature! are sorted by version number #60361

Closed
Centril opened this issue Apr 28, 2019 · 1 comment · Fixed by #60531
Closed

Tidy: Enforce that groups in declare_feature! are sorted by version number #60361

Centril opened this issue Apr 28, 2019 · 1 comment · Fixed by #60531
Assignees
@Centril
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Centril
Copy link
Contributor

Centril commented Apr 28, 2019 •
edited
Loading

In the declare_features! ( ... ) list in src/libsyntax/feature_gate.rs, enforce that groups (internal, user-facing, ...) of features are ordered by version number with the newest last. The groups will need to be scoped in some way with a comment, e.g. // feature group START + feature group END.

This makes it easier to see what things are newer and gives a better overview when considering stabilization.

cc @oli-obk
cc #60354
cc #60362
@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 28, 2019
This was referenced Apr 28, 2019
Merged
Merged
@rasendubi
Copy link
Contributor

I would like to work on this. I think I'll be able to add the feature to tidy, but I'll need help for splitting features into groups.

@rasendubi rasendubi mentioned this issue Apr 29, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60354 - Centril:cleanup-declare-features-ac…
0118c43 
…cepted, r=oli-obk

Cleanup declare_features! for 'accepted' with a uniform style + sort them

r? @oli-obk

cc rust-lang#60362
cc rust-lang#60361
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60362 - Centril:cleanup-declare-features-ac…
54fd023 
…tive, r=oli-obk

Cleanup 'active' declare_features! with uniform style + sorting.

r? @oli-obk

(added the FIXME you wanted)
cc rust-lang#60354
cc rust-lang#60361
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60354 - Centril:cleanup-declare-features-ac…
bfd097e 
…cepted, r=oli-obk

Cleanup declare_features! for 'accepted' with a uniform style + sort them

r? @oli-obk

cc rust-lang#60362
cc rust-lang#60361
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60362 - Centril:cleanup-declare-features-ac…
e3ff055 
…tive, r=oli-obk

Cleanup 'active' declare_features! with uniform style + sorting.

r? @oli-obk

(added the FIXME you wanted)
cc rust-lang#60354
cc rust-lang#60361
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60354 - Centril:cleanup-declare-features-ac…
8000d44 
…cepted, r=oli-obk

Cleanup declare_features! for 'accepted' with a uniform style + sort them

r? @oli-obk

cc rust-lang#60362
cc rust-lang#60361
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60362 - Centril:cleanup-declare-features-ac…
00f626a 
…tive, r=oli-obk

Cleanup 'active' declare_features! with uniform style + sorting.

r? @oli-obk

(added the FIXME you wanted)
cc rust-lang#60354
cc rust-lang#60361
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60354 - Centril:cleanup-declare-features-ac…
17cb922 
…cepted, r=oli-obk

Cleanup declare_features! for 'accepted' with a uniform style + sort them

r? @oli-obk

cc rust-lang#60362
cc rust-lang#60361
Centril added a commit to Centril/rust that referenced this issue Apr 30, 2019
@Centril
Rollup merge of rust-lang#60362 - Centril:cleanup-declare-features-ac…
8a17bbf 
…tive, r=oli-obk

Cleanup 'active' declare_features! with uniform style + sorting.

r? @oli-obk

(added the FIXME you wanted)
cc rust-lang#60354
cc rust-lang#60361
kennytm added a commit to kennytm/rust that referenced this issue May 2, 2019
@kennytm
Rollup merge of rust-lang#60373 - rasendubi:lang-features-sort-since,…
cd08f1c 
… r=Centril

Tidy: ensure lang features are sorted by since

This is the tidy side of rust-lang#60361.

What is left is actually splitting features into groups and sorting by since.

This PR also likely to produce a small (a couple of lines) merge conflict with rust-lang#60362.

r? @Centril
Centril added a commit to Centril/rust that referenced this issue May 2, 2019
@Centril
Rollup merge of rust-lang#60373 - rasendubi:lang-features-sort-since,…
d38096a 
… r=Centril

Tidy: ensure lang features are sorted by since

This is the tidy side of rust-lang#60361.

What is left is actually splitting features into groups and sorting by since.

This PR also likely to produce a small (a couple of lines) merge conflict with rust-lang#60362.

r? @Centril
Centril added a commit to Centril/rust that referenced this issue May 3, 2019
@Centril
Rollup merge of rust-lang#60373 - rasendubi:lang-features-sort-since,…
9199bb5 
… r=Centril

Tidy: ensure lang features are sorted by since

This is the tidy side of rust-lang#60361.

What is left is actually splitting features into groups and sorting by since.

This PR also likely to produce a small (a couple of lines) merge conflict with rust-lang#60362.

r? @Centril
@Centril Centril self-assigned this May 3, 2019
@Centril Centril mentioned this issue May 4, 2019
Merged
bors added a commit that referenced this issue May 7, 2019
@bors
Auto merge of #60531 - Centril:sort-features, r=oli-obk
eeedd3a 
Enforce sorting of accepted and removed features

Fixes #60361 with mechanism introduced in #60373.

r? @oli-obk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Centril Centril

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce sorting of accepted and removed features Centril/rust
2 participants
@Centril @rasendubi