-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be clearer on type mismatch within a range #57389
Comments
@estebank Can I take this one if nobody is working on it? |
@PramodBisht go ahead! |
@PramodBisht Are you still working on this? Or could I take this over? |
@kevgrasso I got occupied with other things, Please take it. Thanks |
@estebank I'm getting some weird behavior from my attempted fix. Most of the bugs I'm getting are understandable, but the one I don't understand is that the text annotating for the primary span in the error diagnostic doesn't show up if I let it display to terminal, but it does if I pipe stderr to a file, and I have no idea what I changed that caused this. Any chance you'd have any clue what might have happened? My changes are here if it helps: https://github.com/kevgrasso/rust/commit/3d37d388e40896f10d6105d80dedd2711d183067 |
|
…, r=estebank typeck: note other end-point when checking range pats Fixes rust-lang#57389, alternative to rust-lang#67214 that should be less invasive to type checking logic. r? @estebank
…, r=estebank typeck: note other end-point when checking range pats Fixes rust-lang#57389, alternative to rust-lang#67214 that should be less invasive to type checking logic. r? @estebank
When matching on a range between two values of different type we currently emit the following output:
We should have a more targeted error:
The text was updated successfully, but these errors were encountered: