You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Xpyder opened this issue
Sep 25, 2018
· 3 comments
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
A seek beyond the end of a stream is allowed, but implementation defined.
so after a little discussion it seems like this might be better wording for those of us who are silly
A seek beyond the end of a stream is allowed, but it is implementation-defined.
The hyphen makes it clear “implementation defined” is a known concept (and matches it’s usage elsewhere) and the “it is” makes it a bit more clear that the full sentence is considered and intentional.
While normally I find brevity improves clarity, in this case if you don’t realize “implementation defined” is a single concept, it sounds like a thought that trailed off after an edit
The text was updated successfully, but these errors were encountered:
sfackler
added
the
A-docs
Area: Documentation for any part of the project, including the compiler, standard library, and tools
label
Sep 25, 2018
shepmaster
changed the title
[easy][documentation] a line in std::io::Seek is confusing for some people
std::io::Seek's documentation about seeking beyond the end of a stream is confusing
Sep 25, 2018
Don't worry about that! It's very easy for developers to misjudge whether such descriptions will make sense to the target users. Pointing these things out is a great way to contribute to documentation.
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
https://doc.rust-lang.org/std/io/trait.Seek.html
std::io::Seek
I got confused by this line and wasted some people's time over on internals.rust
so after a little discussion it seems like this might be better wording for those of us who are silly
The hyphen makes it clear “implementation defined” is a known concept (and matches it’s usage elsewhere) and the “it is” makes it a bit more clear that the full sentence is considered and intentional.
While normally I find brevity improves clarity, in this case if you don’t realize “implementation defined” is a single concept, it sounds like a thought that trailed off after an edit
The text was updated successfully, but these errors were encountered: