NLL: incorrect "unused mut" lint warning, with multiple closures #51904
Assignees
Labels
A-NLL
Area: Non-lexical lifetimes (NLL)
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Comments
|
Tagging as NLL-deferred because #51918 has precedence |
bors
added a commit
that referenced
this issue
Jul 5, 2018
…omatsakis [NLL] Fix various unused mut errors Closes #51801 Closes #50897 Closes #51830 Closes #51904 cc #51918 - keeping this one open in case there are any more issues This PR contains multiple changes. List of changes with examples of what they fix: * Change mir generation so that the parameter variable doesn't get a name when a `ref` pattern is used as an argument ```rust fn f(ref y: i32) {} // doesn't trigger lint ``` * Change mir generation so that by-move closure captures don't get first moved into a temporary. ```rust let mut x = 0; // doesn't trigger lint move || { x = 1; }; ``` * Treat generator upvars the same as closure upvars ```rust let mut x = 0; // This mut is now necessary and is not linted against. move || { x = 1; yield; }; ``` r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Found while trying to bootstrap Rust with NLL enabled, just in case we're not already tracking this incorrect warning (as we're already tracking other similar ones in #51801 and #51830 and more).
Reduced from
libsyntax::parser::parser::parse_dot_or_call_expr_with. Probably not exactly minimal, but smaller than the whole parser :)Repro here on the playground
The text was updated successfully, but these errors were encountered: