Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the organization of the Selectable trait, etc. #5160

Closed
brson opened this issue Feb 28, 2013 · 5 comments
Closed

Fix the organization of the Selectable trait, etc. #5160

brson opened this issue Feb 28, 2013 · 5 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@brson
Copy link
Contributor

brson commented Feb 28, 2013

comm is the user-facing interface to pipes. It currently reexports pipes::Selectable so it can be used by selecti and select2i. This exposes a single detail of core::pipes, which otherwise users don't need to be aware of. Decide whether this trait belongs to pipes or to comm.
@pnkfelix
Copy link
Member

This should probably be folded into Issue #6842.

@pnkfelix
Copy link
Member

(but I won't close it; instead it will remain as a thorn in the side of whomever is implementing #6842. :)

@bblum bblum mentioned this issue Jul 31, 2013
Closed
@bblum
Copy link
Contributor

bblum commented Jul 31, 2013

The same issue exists in the new implementation of select currently in libstd/rt/select.rs. We discussed a plan for fixing the trait definitions in #8008.

@graydon
Copy link
Contributor

graydon commented Jul 31, 2013

Appears to be still relevant. Properly classified, moving on.

@bblum
Copy link
Contributor

bblum commented Jul 31, 2013

Also, the select routine itself can be moved out of the runtime.

@bblum bblum mentioned this issue Aug 6, 2013
Closed
@ghost ghost assigned bblum Aug 6, 2013
@bblum bblum mentioned this issue Aug 9, 2013
Closed
@bblum bblum mentioned this issue Aug 9, 2013
Closed
@bblum bblum closed this as completed in c8c09d4 Aug 13, 2013
@brson brson unassigned bblum Jun 16, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5185 - krishna-veerareddy:issue-5160-lossy-fl…
74f5e34 
…oat-literal, r=flip1995

Lint lossy whole number float literals

changelog: Extend `excessive_precision` to lint lossy whole number float literals

Fixes rust-lang#5160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graydon @brson @pnkfelix @bblum