Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using both no_mangle and export_name attributes should cause a warning #47446

Closed
gamozolabs opened this issue Jan 15, 2018 · 1 comment · Fixed by #131558
Closed

Using both no_mangle and export_name attributes should cause a warning #47446

gamozolabs opened this issue Jan 15, 2018 · 1 comment · Fixed by #131558
Assignees
@sassman
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-linkage Area: linking into static, shared libraries and binaries A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@gamozolabs
Copy link

gamozolabs commented Jan 15, 2018 •
edited by rustbot
Loading

In a simple example like:

#[no_mangle]
#[export_name = "asdf"]
pub extern fn foobar() {}

The actual exported name will be asdf. It seems export_name wins over no_mangle however there is no warning letting you know this occurred. It seems there is no valid use for having both of these so it's probably worth warning about.

-B
@pietroalbini pietroalbini added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 23, 2018
@fmease fmease added A-linkage Area: linking into static, shared libraries and binaries A-attributes Area: Attributes (`#[…]`, `#![…]`) labels May 14, 2024
sassman added a commit to sassman/rust that referenced this issue Oct 11, 2024
@sassman
fix: rust-lang#47446
f6d8242 
- Add test for issue 47446
- Implement the new lint lint_builtin_mixed_export_name_and_no_mangle
- Add suggestion how to fix it
@sassman sassman mentioned this issue Oct 11, 2024
Merged
sassman added a commit to sassman/rust that referenced this issue Oct 11, 2024
@sassman
fix: rust-lang#47446
aa419ee 
- Add test for issue 47446
- Implement the new lint lint_builtin_mixed_export_name_and_no_mangle
- Add suggestion how to fix it
@sassman
Copy link
Contributor

sassman commented Oct 11, 2024

@rustbot claim

sassman added a commit to sassman/rust that referenced this issue Oct 13, 2024
@sassman
fix: rust-lang#47446
3ce170a 
- Add test for issue 47446
- Implement the new lint lint_builtin_mixed_export_name_and_no_mangle
- Add suggestion how to fix it
sassman added a commit to sassman/rust that referenced this issue Oct 13, 2024
@sassman
fix: rust-lang#47446
ea7e38f 
- Add test for issue 47446
- Implement the new lint lint_builtin_mixed_export_name_and_no_mangle
- Add suggestion how to fix it
sassman added a commit to sassman/rust that referenced this issue Oct 20, 2024
@sassman
fix: rust-lang#47446
62f5ce6 
- Add test for issue 47446
- Implement the new lint lint_builtin_mixed_export_name_and_no_mangle
- Add suggestion how to fix it
sassman added a commit to sassman/rust that referenced this issue Oct 29, 2024
@sassman
fix: rust-lang#47446
b68893d 
- Add test for issue 47446
- Implement the new lint lint_builtin_mixed_export_name_and_no_mangle
- Add suggestion how to fix it
sassman added a commit to sassman/rust that referenced this issue Oct 29, 2024
@sassman
fix: rust-lang#47446
1840a42 
- Add test for issue 47446
- Implement the new lint lint_builtin_mixed_export_name_and_no_mangle
- Add suggestion how to fix it
sassman added a commit to sassman/rust that referenced this issue Nov 15, 2024
@sassman
fix: rust-lang#47446
3708c00 
- Add test for issue 47446
- Implement the new lint lint_builtin_mixed_export_name_and_no_mangle
- Add suggestion how to fix it
fmease added a commit to fmease/rust that referenced this issue Dec 9, 2024
@fmease
Rollup merge of rust-lang#131558 - sassman:feat/warnin-for-no-mangle-…
35fc15b 
…together-with-export-name, r=Urgau

Lint on combining `#[no_mangle]` and `#[export_name]`

This is my very first contribution to the compiler, even though I read the [chapter about lints](https://rustc-dev-guide.rust-lang.org/diagnostics.html) I'm not very certain that this ~~new lint is done right as a builtin lint~~ PR is right. I appreciate any guidance on how to improve the code.

- Add test for issue rust-lang#47446
- ~~Implement the new lint `mixed_export_name_and_no_mangle` as a builtin lint (not sure if that is the right way to go)~~ Extend `unused_attributes` lint
- Add suggestion how to fix it

<details>

<summary>Old proposed new lint</summary>

> The `mixed_export_name_and_no_mangle` lint detects usage of both `#[export_name]` and `#[no_mangle]` on the same item which results on `#[no_mangle]` being ignored.
>
> *warn-by-default*
>
> ### Example
>
> ```rust
> #[no_mangle] // ignored
> #[export_name = "foo"] // takes precedences
> pub fn bar() {}
> ```
>
> ### Explanation
>
> The compiler will not respect the `#[no_mangle]` attribute when generating the symbol name for the function, as the `#[export_name]` attribute takes precedence. This can lead to confusion and is unnecessary.

</details>
fmease added a commit to fmease/rust that referenced this issue Dec 9, 2024
@fmease
Rollup merge of rust-lang#131558 - sassman:feat/warnin-for-no-mangle-…
92b2329 
…together-with-export-name, r=Urgau

Lint on combining `#[no_mangle]` and `#[export_name]`

This is my very first contribution to the compiler, even though I read the [chapter about lints](https://rustc-dev-guide.rust-lang.org/diagnostics.html) I'm not very certain that this ~~new lint is done right as a builtin lint~~ PR is right. I appreciate any guidance on how to improve the code.

- Add test for issue rust-lang#47446
- ~~Implement the new lint `mixed_export_name_and_no_mangle` as a builtin lint (not sure if that is the right way to go)~~ Extend `unused_attributes` lint
- Add suggestion how to fix it

<details>

<summary>Old proposed new lint</summary>

> The `mixed_export_name_and_no_mangle` lint detects usage of both `#[export_name]` and `#[no_mangle]` on the same item which results on `#[no_mangle]` being ignored.
>
> *warn-by-default*
>
> ### Example
>
> ```rust
> #[no_mangle] // ignored
> #[export_name = "foo"] // takes precedences
> pub fn bar() {}
> ```
>
> ### Explanation
>
> The compiler will not respect the `#[no_mangle]` attribute when generating the symbol name for the function, as the `#[export_name]` attribute takes precedence. This can lead to confusion and is unnecessary.

</details>
fmease added a commit to fmease/rust that referenced this issue Dec 10, 2024
@fmease
Rollup merge of rust-lang#131558 - sassman:feat/warnin-for-no-mangle-…
94d780d 
…together-with-export-name, r=Urgau

Lint on combining `#[no_mangle]` and `#[export_name]`

This is my very first contribution to the compiler, even though I read the [chapter about lints](https://rustc-dev-guide.rust-lang.org/diagnostics.html) I'm not very certain that this ~~new lint is done right as a builtin lint~~ PR is right. I appreciate any guidance on how to improve the code.

- Add test for issue rust-lang#47446
- ~~Implement the new lint `mixed_export_name_and_no_mangle` as a builtin lint (not sure if that is the right way to go)~~ Extend `unused_attributes` lint
- Add suggestion how to fix it

<details>

<summary>Old proposed new lint</summary>

> The `mixed_export_name_and_no_mangle` lint detects usage of both `#[export_name]` and `#[no_mangle]` on the same item which results on `#[no_mangle]` being ignored.
>
> *warn-by-default*
>
> ### Example
>
> ```rust
> #[no_mangle] // ignored
> #[export_name = "foo"] // takes precedences
> pub fn bar() {}
> ```
>
> ### Explanation
>
> The compiler will not respect the `#[no_mangle]` attribute when generating the symbol name for the function, as the `#[export_name]` attribute takes precedence. This can lead to confusion and is unnecessary.

</details>
@bors bors closed this as completed in 1696f53 Dec 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 10, 2024
@rust-timer
Unrolled build for rust-lang#131558
79254c6 
Rollup merge of rust-lang#131558 - sassman:feat/warnin-for-no-mangle-together-with-export-name, r=Urgau

Lint on combining `#[no_mangle]` and `#[export_name]`

This is my very first contribution to the compiler, even though I read the [chapter about lints](https://rustc-dev-guide.rust-lang.org/diagnostics.html) I'm not very certain that this ~~new lint is done right as a builtin lint~~ PR is right. I appreciate any guidance on how to improve the code.

- Add test for issue rust-lang#47446
- ~~Implement the new lint `mixed_export_name_and_no_mangle` as a builtin lint (not sure if that is the right way to go)~~ Extend `unused_attributes` lint
- Add suggestion how to fix it

<details>

<summary>Old proposed new lint</summary>

> The `mixed_export_name_and_no_mangle` lint detects usage of both `#[export_name]` and `#[no_mangle]` on the same item which results on `#[no_mangle]` being ignored.
>
> *warn-by-default*
>
> ### Example
>
> ```rust
> #[no_mangle] // ignored
> #[export_name = "foo"] // takes precedences
> pub fn bar() {}
> ```
>
> ### Explanation
>
> The compiler will not respect the `#[no_mangle]` attribute when generating the symbol name for the function, as the `#[export_name]` attribute takes precedence. This can lead to confusion and is unnecessary.

</details>
@Robbepop Robbepop mentioned this issue Dec 28, 2024
Merged
Robbepop added a commit to wasmi-labs/wasmi that referenced this issue Jan 6, 2025
@Robbepop
clippy: fix no_mangle and export_name usage
da5d89c 
The no_mangle and export_name attributes cannot be used at the same time.
(Link: rust-lang/rust#47446)
Since Clippy now warns about this we were notified about our misuse and this PR fixes it.
@Robbepop Robbepop mentioned this issue Jan 6, 2025
Merged
Robbepop added a commit to wasmi-labs/wasmi that referenced this issue Jan 6, 2025
@Robbepop
clippy: fix no_mangle and export_name usage (#1337)
559c167 
clippy: fix no_mangle and export_name usage

The no_mangle and export_name attributes cannot be used at the same time.
(Link: rust-lang/rust#47446)
Since Clippy now warns about this we were notified about our misuse and this PR fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sassman sassman

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-linkage Area: linking into static, shared libraries and binaries A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lint on combining #[no_mangle] and #[export_name] sassman/rust
4 participants
@sassman @pietroalbini @gamozolabs @fmease