Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token quote should be able to unquote a single token #39746

Closed
nrc opened this issue Feb 11, 2017 · 0 comments · Fixed by #40532
Closed

token quote should be able to unquote a single token #39746

nrc opened this issue Feb 11, 2017 · 0 comments · Fixed by #40532
Assignees
@jseyfried
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)

Comments

@nrc
Copy link
Member

nrc commented Feb 11, 2017

At the moment it can only unquote a TokenStream.

E.g., this should work:

let f = token::Ident("foo");
qquote!(let unquote f = blah;);

Also, we should have syntax for unquote, but that is unrelated.
@nrc nrc added the A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) label Feb 11, 2017
@jseyfried jseyfried self-assigned this Mar 14, 2017
@jseyfried jseyfried mentioned this issue Mar 14, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40532 - jseyfried:improve_tokenstream_quote…
8db0914 
…r, r=nrc

macros: improve the `TokenStream` quoter

This PR
 - renames the `TokenStream` quoter from `qquote!` to `quote!`,
 - uses `$` instead of `unquote` (e.g. `let toks: TokenStream = ...; quote!([$toks])`),
 - allows unquoting `Token`s as well as `TokenTree`s and `TokenStream`s (fixes rust-lang#39746), and
 - to preserve syntactic space, requires that `$` be followed by
   - a single identifier to unquote, or
   - another `$` to produce a literal `$`.

r? @nrc
arielb1 pushed a commit to arielb1/rust that referenced this issue Mar 18, 2017
Rollup merge of rust-lang#40532 - jseyfried:improve_tokenstream_quote…
663409b 
…r, r=nrc

macros: improve the `TokenStream` quoter

This PR
 - renames the `TokenStream` quoter from `qquote!` to `quote!`,
 - uses `$` instead of `unquote` (e.g. `let toks: TokenStream = ...; quote!([$toks])`),
 - allows unquoting `Token`s as well as `TokenTree`s and `TokenStream`s (fixes rust-lang#39746), and
 - to preserve syntactic space, requires that `$` be followed by
   - a single identifier to unquote, or
   - another `$` to produce a literal `$`.

r? @nrc
arielb1 pushed a commit to arielb1/rust that referenced this issue Mar 19, 2017
Rollup merge of rust-lang#40532 - jseyfried:improve_tokenstream_quote…
584f1b6 
…r, r=nrc

macros: improve the `TokenStream` quoter

This PR
 - renames the `TokenStream` quoter from `qquote!` to `quote!`,
 - uses `$` instead of `unquote` (e.g. `let toks: TokenStream = ...; quote!([$toks])`),
 - allows unquoting `Token`s as well as `TokenTree`s and `TokenStream`s (fixes rust-lang#39746), and
 - to preserve syntactic space, requires that `$` be followed by
   - a single identifier to unquote, or
   - another `$` to produce a literal `$`.

r? @nrc
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 20, 2017
@frewsxcv
Rollup merge of rust-lang#40532 - jseyfried:improve_tokenstream_quote…
7471d97 
…r, r=nrc

macros: improve the `TokenStream` quoter

This PR
 - renames the `TokenStream` quoter from `qquote!` to `quote!`,
 - uses `$` instead of `unquote` (e.g. `let toks: TokenStream = ...; quote!([$toks])`),
 - allows unquoting `Token`s as well as `TokenTree`s and `TokenStream`s (fixes rust-lang#39746), and
 - to preserve syntactic space, requires that `$` be followed by
   - a single identifier to unquote, or
   - another `$` to produce a literal `$`.

r? @nrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jseyfried jseyfried

Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

macros: improve the TokenStream quoter jseyfried/rust
2 participants
@nrc @jseyfried