Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite serialization to use reflection #3714

Closed
erickt opened this issue Oct 10, 2012 · 2 comments
Closed

Rewrite serialization to use reflection #3714

erickt opened this issue Oct 10, 2012 · 2 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@erickt
Copy link
Contributor

erickt commented Oct 10, 2012

We need to use a syntax extension to automatically build serializers for records, structs, and enums. Instead, we should switch over to using the visitor-based reflection facilities.
@nikomatsakis
Copy link
Contributor

I am not sure this is a good idea. Some types must have specialized serialization. A deriving-based solution may be more appropriate. (auto_serialize is essentially deriving, of course)

@bstrie
Copy link
Contributor

bstrie commented Apr 30, 2013

erickt doesn't think this is still relevant.

@bstrie bstrie closed this as completed Apr 30, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jun 29, 2024
@bors
Auto merge of rust-lang#3715 - cgettys-microsoft:dev/cgettys/process_…
340b98a 
…id_fixup-01, r=RalfJung

Fix miri.bat to not exit unconditionally

rust-lang#3703 has a small typo causing it to regress ./miri.bat to not working at all.

This PR fixes it. Tested on Windows 11, with stable toolchain missing as well as installed.
```test
./miri toolchain
error: toolchain 'stable-x86_64-pc-windows-msvc' is not installed
Failed to build miri-script. Is the 'stable' toolchain installed?
```

Closes rust-lang#3714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erickt @nikomatsakis @bstrie