Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate lang items from external sources results in panic #32961

Closed
taralx opened this issue Apr 14, 2016 · 0 comments
Closed

Duplicate lang items from external sources results in panic #32961

taralx opened this issue Apr 14, 2016 · 0 comments

Comments

@taralx
Copy link
Contributor

taralx commented Apr 14, 2016

If we get duplicate lang items from external crates, we crash at

rust/src/librustc/middle/lang_items.rs

Line 193 in 073a09f

.expect("we should have found local duplicate earlier");
because we don't have a local span for the duplicate.
@taralx taralx mentioned this issue Apr 14, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 15, 2016
@Manishearth
Rollup merge of rust-lang#32970 - taralx:patch-2, r=alexcrichton
00d4ac3 
Accommodate the case where dup lang items are entirely external.

Fixes rust-lang#32961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taralx