Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused functions in objects can affect whether self calls compile #324

Closed
lkuper opened this issue Apr 8, 2011 · 2 comments
Closed

Unused functions in objects can affect whether self calls compile #324

lkuper opened this issue Apr 8, 2011 · 2 comments

Comments

@lkuper
Copy link
Contributor

lkuper commented Apr 8, 2011

https://gist.github.com/654a2ffb1b6a0a50ffb0

Should compile and run as expected -- but commenting out the (unused!) 'wrapper' fn produces:

rust: ../rust/src/test/run-pass/obj-self-4.rs:11:19:11:26: error: mismatched types: expected fn(int) -> but found fn() -> int (incorrect number of function parameters)

11:19:11:26 is the call to 'inc_by' inside 'inc_by_5'.
@graydon
Copy link
Contributor

graydon commented May 26, 2011

Is this still occurring?

@lkuper
Copy link
Contributor Author

lkuper commented May 27, 2011

Just committed a test case showing that this has been fixed sometime in the last several weeks. (Wish I'd been keeping track of what fixed it, though.) Closing this issue.

@lkuper lkuper closed this as completed May 27, 2011
oli-obk pushed a commit to oli-obk/rust that referenced this issue Sep 19, 2017
@RalfJung
Merge pull request rust-lang#324 from oli-obk/align_offset
ee5383f 
Implement `align_offset` intrinsic and thus enabling `from_utf8`
kazcw pushed a commit to kazcw/rust that referenced this issue Oct 23, 2018
@alexcrichton
Reorganize and refactor source tree (rust-lang#324)
80a524d 
With RFC 2325 looking close to being accepted, I took a crack at
reorganizing this repository to being more amenable for inclusion in
libstd/libcore. My current plan is to add stdsimd as a submodule in
rust-lang/rust and then use `#[path]` to include the modules directly
into libstd/libcore.

Before this commit, however, the source code of coresimd/stdsimd
themselves were not quite ready for this. Imports wouldn't compile for
one reason or another, and the organization was also different than the
RFC itself!

In addition to moving a lot of files around, this commit has the
following major changes:

* The `cfg_feature_enabled!` macro is now renamed to
  `is_target_feature_detected!`
* The `vendor` module is now called `arch`.
* Under the `arch` module is a suite of modules like `x86`, `x86_64`,
  etc. One per `cfg!(target_arch)`.
* The `is_target_feature_detected!` macro was removed from coresimd.
  Unfortunately libcore has no ability to export unstable macros, so for
  now all feature detection is canonicalized in stdsimd.

The `coresimd` and `stdsimd` crates have been updated to the planned
organization in RFC 2325 as well. The runtime bits saw the largest
amount of refactoring, seeing a good deal of simplification without the
core/std split.
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@alercah
Merge pull request rust-lang#324 from durka/stabilize-macro-lifetime
11931e8 
document :lifetime
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Oct 26, 2020
@bjorn3
Merge pull request rust-lang#324 from bjorn3/dependabot/cargo/fuchsia…
f78c99e 
…-cprng-0.1.1

Bump fuchsia-cprng from 0.1.0 to 0.1.1
antoyo added a commit to antoyo/rust that referenced this issue Oct 9, 2023
@antoyo
Merge pull request rust-lang#324 from GuillaumeGomez/no-alias-optimiz…
b6ccb55 
…ation

Only apply NoAlias attribute if optimization is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @lkuper