Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime makefile doesn't properly handle header dependency #2547

Closed
msullivan opened this issue Jun 8, 2012 · 2 comments
Closed

runtime makefile doesn't properly handle header dependency #2547

msullivan opened this issue Jun 8, 2012 · 2 comments

Comments

@msullivan
Copy link
Contributor

The build system for the runtime doesn't handle dependency on header files. There are common approaches for dealing with this. (Probably the most common approach is "screw it, I'll just use autotools", but there are better ones that that...)
@ghost ghost assigned msullivan Jun 8, 2012
@marijnh marijnh mentioned this issue Jun 13, 2012
Closed
@msullivan
Copy link
Contributor Author

It looks like the build system tries to make all of the runtime object files depend on all of the header files, using wildcard to get all the .h files in the rt/ directory. This doesn't work, since the wildcard will be expanded in the current directory (that is, the build directory). Instead of trying to fix that, I'm going to do it right way and get the compiler to generate header dependency information.

@msullivan msullivan reopened this Jun 14, 2012
@msullivan
Copy link
Contributor Author

The change burned OS X, so I had to back it out.

lkuper pushed a commit to lkuper/rust that referenced this issue Jun 14, 2012
@msullivan
Revert "Update the build system to handle dependency on header files. C…
3a36ffe 
…loses rust-lang#2547."

This reverts commit 31f4b63.
@msullivan msullivan removed their assignment Jun 16, 2014
oli-obk pushed a commit to oli-obk/rust that referenced this issue Sep 19, 2022
@bors
Auto merge of rust-lang#2547 - RalfJung:fake-apis, r=saethlin
0def954 
note on deterministic 'fake' API implementations

Now that we also have fake clocks, it seems prudent to warn about this at the top of the readme.

r? `@rust-lang/miri`
This was referenced Oct 22, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msullivan