Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup in syntax::ext::simpleext #2251

Closed
catamorphism opened this issue Apr 19, 2012 · 2 comments
Closed

Cleanup in syntax::ext::simpleext #2251

catamorphism opened this issue Apr 19, 2012 · 2 comments
Labels
A-syntaxext Area: Syntax extensions C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
old 1.0 milestone

Comments

@catamorphism
Copy link
Contributor

Two FIXMEs in simpleext: "/* FIXME: handle embedded types and blocks, at least */" in p_t_s_rec and "FIXME: check duplicates (or just simplify the macro arg situation)" in add_new_extension. I don't pretend to have any understanding of this code, so that's all I'll say.

The first one at least seems to have been added by @marijnh , so assigning to him.
@ghost ghost assigned marijnh Apr 19, 2012
@marijnh
Copy link
Contributor

marijnh commented Apr 20, 2012

I never saw this code before either, so I'm going to pass.

@graydon
Copy link
Contributor

graydon commented Mar 12, 2013

dead code, closing

@graydon graydon closed this as completed Mar 12, 2013
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2251 - dtolnay-contrib:rustfmt4, r=RalfJung
7a1b08e 
Format tests with rustfmt (201-224 of 300)

Extracted from rust-lang#2097. Last of the easy cases which do not involve moving around a comment.
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@remi-delmas-3000
Update CBMC version to 5.78 (rust-lang#2251)
33bdc6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-syntaxext Area: Syntax extensions C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
3 participants
@graydon @marijnh @catamorphism