Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: StdWriter::isatty doesn't show up in search #17332

Closed
lilyball opened this issue Sep 17, 2014 · 1 comment · Fixed by #19515
Closed

rustdoc: StdWriter::isatty doesn't show up in search #17332

lilyball opened this issue Sep 17, 2014 · 1 comment · Fixed by #19515
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lilyball
Copy link
Contributor

Searching rustdoc for "isatty" shows std::io::stdio::StdReader::isatty but it doesn't show std::io::stdio::StdWriter::isatty.

http://doc.rust-lang.org/std/index.html?search=isatty

However the docs on StdWriter clearly show the function.

http://doc.rust-lang.org/std/io/stdio/struct.StdWriter.html
@lilyball lilyball added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 17, 2014
@tomjakubowski
Copy link
Contributor

I thought this was fixed, but it seems like the situation is now reversed! StdWriter::isatty shows in the search results for me, but not StdReader::isatty. Looks like it's a problem in the JS pruning search results; both methods are definitely in the index generated by rustdoc.

lifthrasiir added a commit to lifthrasiir/rust that referenced this issue Dec 4, 2014
@lifthrasiir
rustdoc: Do not deduplicate items when their parents differ.
a12b839 
Fixes rust-lang#17332.
@lifthrasiir lifthrasiir mentioned this issue Dec 4, 2014
Merged
lnicola pushed a commit to lnicola/rust that referenced this issue Jun 23, 2024
@bors
Auto merge of rust-lang#17333 - DropDemBits:extract-format-args-snipp…
fcde6c9 
…et-cap, r=Veykril

fix: Only generate snippets for `extract_expressions_from_format_string` if snippets are supported

Part of rust-lang#17332

Fixes `extract_expressions_from_format_string` so that it doesn't generate snippets if the client doesn't support it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Do not deduplicate items when their parents differ. lifthrasiir/rust
2 participants
@lilyball @tomjakubowski