Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable DEP on 32-bit Windows #16533

Closed
thestinger opened this issue Aug 16, 2014 · 0 comments · Fixed by #16534
Closed

enable DEP on 32-bit Windows #16533

thestinger opened this issue Aug 16, 2014 · 0 comments · Fixed by #16534
Labels
A-security Area: Security (example: address space layout randomization). C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows

Comments

@thestinger
Copy link
Contributor

DEP (NX bit) is enabled by default on 64-bit, but it requires opting in on 32-bit.
This was referenced Aug 16, 2014
Merged
Closed
bors added a commit that referenced this issue Aug 16, 2014
@bors
auto merge of #16534 : thestinger/rust/dep, r=huonw
22b7e4d 
This is already enabled by default for x86_64 executables on Windows,
but it needs to be manually enabled on x86.

Closes #16533
@nmathewson nmathewson mentioned this issue Jul 27, 2022
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 18, 2024
@bors
Auto merge of rust-lang#16533 - Nadrieril:update-pat-ana, r=HKalbasi
b7972e5 
Update to latest `rustc_pattern_analysis`

Here I go again. Two improvements this time.

1. I've removed the need for an arena for patterns. Turns out this wasn't gaining any performance on the rustc side so may as well allocate normally.
2. I've added a clean error path when types don't match, so rustc_pattern_analysis should never panic except internal logic errors. For now `cx.bug()` calls `never!()` but I'm not sure what `never!()` does. Does it display anything to the user? Otherwise a `debug!()` should be sufficient.

Point 2 should fix rust-lang/rust-analyzer#15883 but I haven't tested it because I'm not sure how to reproduce. Could someone give me pointers as to how to write a test for the pattern code?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-security Area: Security (example: address space layout randomization). C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable DEP (NX bit) for 32-bit Windows executables
1 participant
@thestinger