Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Share to Sync #16281

Closed
nikomatsakis opened this issue Aug 5, 2014 · 0 comments
Closed

Rename Share to Sync #16281

nikomatsakis opened this issue Aug 5, 2014 · 0 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 5, 2014 •
edited by dtolnay
Loading

Tracking issue for rust-lang/rfcs#123
@alexcrichton alexcrichton changed the title Rename share to threadsafe [Tracking issue for RFC 45] Rename Share to Sync [Tracking issue for RFC 45] Aug 5, 2014
@alexcrichton alexcrichton mentioned this issue Aug 6, 2014
Closed
bors added a commit that referenced this issue Aug 8, 2014
@bors
auto merge of #16285 : alexcrichton/rust/rename-share, r=huonw
aae7901 
This leaves the `Share` trait at `std::kinds` via a `#[deprecated]` `pub use`
statement, but the `NoShare` struct is no longer part of `std::kinds::marker`
due to #12660 (the build cannot bootstrap otherwise).

All code referencing the `Share` trait should now reference the `Sync` trait,
and all code referencing the `NoShare` type should now reference the `NoSync`
type. The functionality and meaning of this trait have not changed, only the
naming.

Closes #16281
[breaking-change]
@dtolnay dtolnay changed the title Rename Share to Sync [Tracking issue for RFC 45] Rename Share to Sync Jun 15, 2019
@dtolnay dtolnay added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Share to Sync alexcrichton/rust
2 participants
@nikomatsakis @dtolnay