Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismantle std::unstable #1457

Closed
brson opened this issue Jan 8, 2012 · 8 comments
Closed

Dismantle std::unstable #1457

brson opened this issue Jan 8, 2012 · 8 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Jan 8, 2012

core and std have extfmt and test modules which just provide compiler support and aren't intended to provide a user-facing API. We should have some convention for where they should be hidden away. In particular, "test" is a module where I would like to put useful things for writing tests, not the infrastructure code that's there now.
@brson
Copy link
Contributor Author

brson commented Mar 12, 2012

I have made it so that these mods don't appear in the documentation, so that's a start

@brson
Copy link
Contributor Author

brson commented Mar 14, 2012

Punting on this for 0.2

@ghost ghost assigned brson Apr 12, 2012
@msullivan
Copy link
Contributor

Is this still something we want?

@alexcrichton
Copy link
Member

@brson, how much of this was done with the move of things into unstable? It definitely conveys the meaning of "this shouldn't be user facing" although it still is...

@catamorphism
Copy link
Contributor

Still more to discuss here; tagging as priority so we can have that discussion.

@brson
Copy link
Contributor Author

brson commented Sep 26, 2013

@alexcrichton some. e.g. a lot of lang items and intrinsics are under unstable. A lot of what is currently in unstable will move out and be tagged #[unstable], leaving the unstable module probably misnamed. Could possibly be renamed to private or internal or something.

brson added a commit to brson/rust that referenced this issue Feb 16, 2014
@brson
std: Move intrinsics to std::intrinsics.
598f01d 
Issue rust-lang#1457
brson added a commit to brson/rust that referenced this issue Feb 23, 2014
@brson
std: Move intrinsics to std::intrinsics.
4d10bdc 
Issue rust-lang#1457
brson added a commit to brson/rust that referenced this issue Feb 23, 2014
@brson
std: Move raw to std::raw
3e57808 
Issue rust-lang#1457
brson added a commit to brson/rust that referenced this issue May 23, 2014
@brson
std: Move running_on_valgrind to rt::util. rust-lang#1457
dcd20e2 
[breaking-change]
brson added a commit to brson/rust that referenced this issue May 23, 2014
@brson
std: Move simd to core::simd and reexport. rust-lang#1457
473a545 
[breaking-change]
brson added a commit to brson/rust that referenced this issue May 23, 2014
@brson
std: Move unstable::finally to std::finally. rust-lang#1457
d1f2737 
[breaking-change]
brson added a commit to brson/rust that referenced this issue May 23, 2014
@brson
std: Move running_on_valgrind to rt::util. rust-lang#1457
1240197 
[breaking-change]
brson added a commit to brson/rust that referenced this issue May 23, 2014
@brson
std: Move simd to core::simd and reexport. rust-lang#1457
1a1e6c8 
[breaking-change]
brson added a commit to brson/rust that referenced this issue May 23, 2014
@brson
std: Move unstable::finally to std::finally. rust-lang#1457
8e58ec5 
[breaking-change]
thehydroimpulse added a commit to thehydroimpulse/rust that referenced this issue May 27, 2014
@thehydroimpulse
Moved std::unstable::mutex to std::rt.
5122412 
This is to cleanout the std::unstable module and use the appropriate
unstable attribute. This mutex module is **not** supposed to be
used outside of the compiler/std.

This change is according to rust-lang#1457 and comment
rust-lang#1457 (comment)

[breaking-change]
@brson brson mentioned this issue Jun 9, 2014
Closed
brson added a commit to brson/rust that referenced this issue Jun 9, 2014
@brson
std: Move dynamic_lib from std::unstable to std
fb2a956 
This leaves a deprecated reexport in place temporarily.

Closes rust-lang#1457.
@brson brson closed this as completed in 1635ef2 Jun 10, 2014
mcpherrinm pushed a commit to mcpherrinm/rust that referenced this issue Jun 10, 2014
@brson @mcpherrinm
std: Move dynamic_lib from std::unstable to std
b2049fa 
This leaves a deprecated reexport in place temporarily.

Closes rust-lang#1457.
bjorn3 added a commit to bjorn3/rust that referenced this issue Mar 8, 2024
@bjorn3
Merge pull request rust-lang#1457 from uweigand/simd-endian
ba7404a 
Fix simd_select_bitmask on big-endian systems
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@danielsn
Cleanup TagEncoding::Direct. Instead of using a function to create a …
eae6460 
…temporary, just directly create the rvalue we need (rust-lang#1457)
Kobzol pushed a commit to Kobzol/rust that referenced this issue Dec 30, 2024
@ssbr @JohnTitor
Add symbol-addition to the how-to for new features (rust-lang#1457)
27d9b16 
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
@ssbr @JohnTitor
Add symbol-addition to the how-to for new features (rust-lang#1457)
072e5eb 
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

std: Move dynamic_lib from std::unstable to std brson/rust
5 participants
@alexcrichton @brson @msullivan @catamorphism @emberian