Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make check -j8 fails because it can't find the regex crate #13818

Closed
nrc opened this issue Apr 28, 2014 · 5 comments
Closed

make check -j8 fails because it can't find the regex crate #13818

nrc opened this issue Apr 28, 2014 · 5 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@nrc
Copy link
Member

nrc commented Apr 28, 2014

make check works just fine though.
@nrc
Copy link
Member Author

nrc commented Apr 28, 2014

Er, to be precise we fail in one of the compile-fail regex tests.

@lifthrasiir
Copy link
Contributor

We need a metabug for missing make dependencies. Oh, that's #8058.

@alexcrichton
Copy link
Member

Was the missing crate specifically the regex crate or was it the regex_macros crate?

This is likely because the compile-fail tests do not depend on HOST_CRATES, which notable includes regex_macros. Fixing this would likely involve adding a compile-fail-fulldeps folder.

@nrc
Copy link
Member Author

nrc commented Apr 28, 2014

ah yes, regex_macros - sorry, it was late

@alexcrichton alexcrichton mentioned this issue Apr 29, 2014
Closed
bors added a commit that referenced this issue May 7, 2014
@bors
auto merge of #13832 : alexcrichton/rust/cfail-full, r=brson
445988b 
Compile-fail tests for syntax extensions belong in this suite which has correct
dependencies on all artifacts rather than just the target artifacts.

Closes #13818
@kmcallister
Copy link
Contributor

I ran into this on today's master.

arcnmx pushed a commit to arcnmx/rust that referenced this issue Jan 9, 2023
@bors
Auto merge of rust-lang#13818 - Veykril:layout, r=Veykril
113f17b 
Simplify
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 15, 2024
@y21
fix version attribute for arbitrary_source_item_ordering lint (rust…
f2aed50 
…-lang#13819)

fix rust-lang#13818

The `arbitrary_source_item_ordering` lint does not exist in v1.82.0, so
I think it needs to be fixed.

changelog: [`arbitrary_source_item_ordering`]: corrected available
version information for this lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add a compile-fail-fulldeps test suite alexcrichton/rust
5 participants
@alexcrichton @lifthrasiir @kmcallister @nrc @huonw