Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_fluent_macro::fluent_messages uses CARGO_PKG_NAME instead of CARGO_CRATE_NAME #137815

Closed
lolbinarycat opened this issue Feb 28, 2025 · 1 comment · Fixed by #137834
Closed

rustc_fluent_macro::fluent_messages uses CARGO_PKG_NAME instead of CARGO_CRATE_NAME #137815

lolbinarycat opened this issue Feb 28, 2025 · 1 comment · Fixed by #137834
Assignees
@lolbinarycat
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@lolbinarycat
Copy link
Contributor

the crate name is an identifier used by rustc, and cannot contain hyphens.

the package name is only used by cargo, and can contain hyphens.

the issue is at compiler/rustc_fluent_macro/fluent.rs.html:81
@lolbinarycat lolbinarycat added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 28, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 28, 2025
@lolbinarycat
Copy link
Contributor Author

this causes problems if anyone tries to make a compiler plugin with hyphens in the package name.

@lolbinarycat lolbinarycat self-assigned this Mar 1, 2025
@lolbinarycat lolbinarycat mentioned this issue Mar 1, 2025
Merged
@Noratrieb Noratrieb removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 1, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Mar 4, 2025
@workingjubilee
Rollup merge of rust-lang#137834 - lolbinarycat:rustc_fluent_macro-13…
96ed4ec 
…7815, r=BoxyUwU

rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME

fixes rust-lang#137815
Noratrieb added a commit to Noratrieb/rust that referenced this issue Mar 6, 2025
@Noratrieb
Rollup merge of rust-lang#137834 - lolbinarycat:rustc_fluent_macro-13…
66cc399 
…7815, r=BoxyUwU

rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME

fixes rust-lang#137815
compiler-errors added a commit to compiler-errors/rust that referenced this issue Mar 6, 2025
@compiler-errors
Rollup merge of rust-lang#137834 - lolbinarycat:rustc_fluent_macro-13…
56f0a60 
…7815, r=BoxyUwU

rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME

fixes rust-lang#137815
@bors bors closed this as completed in 38b364b Mar 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#137834
e571709 
Rollup merge of rust-lang#137834 - lolbinarycat:rustc_fluent_macro-137815, r=BoxyUwU

rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME

fixes rust-lang#137815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolbinarycat lolbinarycat

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME lolbinarycat/rust
3 participants
@lolbinarycat @rustbot @Noratrieb