Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for String::into_chars #133125

Open
1 of 4 tasks
tisonkun opened this issue Nov 17, 2024 · 0 comments
Open
1 of 4 tasks

Tracking Issue for String::into_chars #133125

tisonkun opened this issue Nov 17, 2024 · 0 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Nov 17, 2024

Feature gate: #![feature(string_into_chars)]

This is a tracking issue for:

  • String::into_chars

Public API

impl String {
    pub fn into_chars(self) -> IntoChars {
        IntoChars { bytes: self.into_bytes().into_iter() }
    }
}

impl Iterator for IntoChars {
    type Item = char;
}

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html

@tisonkun tisonkun added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 17, 2024
jhpratt added a commit to jhpratt/rust that referenced this issue Jan 8, 2025
Impl String::into_chars

Tracking issue - rust-lang#133125

r? `@programmerjake` `@kennytm` `@Amanieu`

This refers to rust-lang/libs-team#268

Before adding tests and creating a tracking issue, I'd like to reach a consensus on the implementation direction and two questions:

1. Whether we'd add a `String::into_char_indices` method also?
2. See inline comment.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 8, 2025
Rollup merge of rust-lang#133057 - tisonkun:into-chars, r=Amanieu

Impl String::into_chars

Tracking issue - rust-lang#133125

r? `@programmerjake` `@kennytm` `@Amanieu`

This refers to rust-lang/libs-team#268

Before adding tests and creating a tracking issue, I'd like to reach a consensus on the implementation direction and two questions:

1. Whether we'd add a `String::into_char_indices` method also?
2. See inline comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

1 participant