-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The target information for mips64-openwrt-linux-musl
seems wrong
#131165
Comments
In my understanding, As for -muslabi64 vs -musl, I guess abi64 was omitted because openwrt does not support other ABIs. (MIPS64 has another ABI called N32) |
…ieyouxu Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl` OpenWRT is a Linux distribution for embedded network devices. The target name contains `openwrt`, so we should set `cfg(target_vendor = "openwrt")`. This is similar to what other Linux distributions do (the only one in-tree is `x86_64-unikraft-linux-musl`, but that sets `target_vendor = "unikraft"`). Motivation: To make correctly [parsing target names](rust-lang/cc-rs#1413) simpler. Fixes rust-lang#131165. CC target maintainer `@Itus-Shield`
…ieyouxu Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl` OpenWRT is a Linux distribution for embedded network devices. The target name contains `openwrt`, so we should set `cfg(target_vendor = "openwrt")`. This is similar to what other Linux distributions do (the only one in-tree is `x86_64-unikraft-linux-musl`, but that sets `target_vendor = "unikraft"`). Motivation: To make correctly [parsing target names](rust-lang/cc-rs#1413) simpler. Fixes rust-lang#131165. CC target maintainer ``@Itus-Shield``
Target triples are generally
arch-vendor-os-env
(with lots of exceptions), but themips64-openwrt-linux-musl
target (added in #92300) seems to be confused about the vendor?The target
cfg
s are currently (trimmed fromrustc --print cfg --target mips64-openwrt-linux-musl
):I think there's a few ways to fix this:
target_vendor="openwrt"
.mips64-unknown-openwrt-musl
or similar, and settarget_os="openwrt"
.target_abi = "abi64"
, and so the target name should containmuslabi64
.CC target maintainer @Itus-Shield
The text was updated successfully, but these errors were encountered: