Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for RFC 3637: Guard patterns #129967

Open
2 tasks done
traviscross opened this issue Sep 4, 2024 · 2 comments
Open
2 tasks done

Tracking issue for RFC 3637: Guard patterns #129967

traviscross opened this issue Sep 4, 2024 · 2 comments
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-guard_patterns `#![feature(guard_patterns)]` T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Sep 4, 2024 •
edited by Nadrieril
Loading

This is a tracking issue for XXX.

The feature gate for the issue is #![feature(guard_patterns)].

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • Should we allow mismatched bindings when possible in pattern disjunctions?
  • How should we refer to "guard patterns"?

Implementation history
Preview Give feedback
  1. Implement Guard Patterns down to THIR #129996
    S-waiting-on-author T-compiler T-rustdoc
    cjgillot
  2. Parse guard patterns #133424
    S-waiting-on-bors T-compiler
    fee1-dead

cc @max-niederman
@traviscross traviscross added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-lang Relevant to the language team, which will review and decide on the PR/issue. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Sep 4, 2024
@traviscross traviscross mentioned this issue Sep 4, 2024
Merged
@traviscross traviscross added the F-guard_patterns `#![feature(guard_patterns)]` label Sep 4, 2024
@ShE3py ShE3py mentioned this issue Sep 5, 2024
Merged
@max-niederman max-niederman mentioned this issue Sep 5, 2024
Closed
@safinaskar

This comment has been minimized.

Sign in to view
@traviscross

This comment has been minimized.

Sign in to view
@Nadrieril Nadrieril mentioned this issue Nov 24, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#133424 - Nadrieril:guard-patterns-parsing, …
1868c8f 
…r=fee1-dead

Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang#129967)). This PR is extracted from rust-lang#129996 with minor modifications.

cc `@max-niederman`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 9, 2024
@rust-timer
Unrolled build for rust-lang#133424
2bad485 
Rollup merge of rust-lang#133424 - Nadrieril:guard-patterns-parsing, r=fee1-dead

Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang#129967)). This PR is extracted from rust-lang#129996 with minor modifications.

cc `@max-niederman`
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue Dec 15, 2024
@matthiaskrgr
Rollup merge of #133424 - Nadrieril:guard-patterns-parsing, r=fee1-dead
24ccb15 
Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang/rust#129967)). This PR is extracted from rust-lang/rust#129996 with minor modifications.

cc `@max-niederman`
@dtolnay dtolnay mentioned this issue Dec 15, 2024
Open
@max-niederman max-niederman mentioned this issue Jan 1, 2025
Merged
github-actions bot pushed a commit to ytmimi/rustfmt that referenced this issue Jan 2, 2025
@matthiaskrgr
Rollup merge of #133424 - Nadrieril:guard-patterns-parsing, r=fee1-dead
8073aab 
Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang/rust#129967)). This PR is extracted from rust-lang/rust#129996 with minor modifications.

cc `@max-niederman`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#134989 - max-niederman:guard-patterns-hir, …
ebbbf0f 
…r=oli-obk

Lower Guard Patterns to HIR.

Implements lowering of [guard patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see the [tracking issue](rust-lang#129967)) to HIR.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#134989 - max-niederman:guard-patterns-hir, …
a20d0d5 
…r=oli-obk

Lower Guard Patterns to HIR.

Implements lowering of [guard patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see the [tracking issue](rust-lang#129967)) to HIR.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 8, 2025
@rust-timer
Unrolled build for rust-lang#134989
e829f03 
Rollup merge of rust-lang#134989 - max-niederman:guard-patterns-hir, r=oli-obk

Lower Guard Patterns to HIR.

Implements lowering of [guard patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see the [tracking issue](rust-lang#129967)) to HIR.
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#134989 - max-niederman:guard-patterns-hir, …
11f38ad 
…r=oli-obk

Lower Guard Patterns to HIR.

Implements lowering of [guard patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see the [tracking issue](rust-lang#129967)) to HIR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-guard_patterns `#![feature(guard_patterns)]` T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@safinaskar @traviscross