Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename config.toml to bootstrap.toml #126875

Open
jyn514 opened this issue Jun 23, 2024 · 6 comments · May be fixed by #137081
Open

rename config.toml to bootstrap.toml #126875

jyn514 opened this issue Jun 23, 2024 · 6 comments · May be fixed by #137081
Assignees
@Shourya742
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 23, 2024 •
edited by rustbot
Loading

cargo and bootstrap use the same name for their configuration file. this is confusing. we might want to rename this file so it's easier to understand what's going on.

this will also make it easier to write .gitignore style includes and excludes without mixing up the two types of configs.

@rustbot label A-contributor-roadblock T-bootstrap E-easy E-mentor
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 23, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 24, 2024
@onur-ozkan
Copy link
Member

If we do that, if bootstrap.toml don't exist we should fallback to config.toml so we don't break the downstreams.

@Noratrieb Noratrieb mentioned this issue Jul 7, 2024
Merged
@Noratrieb
Copy link
Member

our docs have also been confused about this before: #127236

@LuuuXXX
Copy link
Contributor

LuuuXXX commented Jul 8, 2024

Any progress on this? I'm happy to help.

@onur-ozkan
Copy link
Member

Any progress on this? I'm happy to help.

Feel free to claim the task.

@LuuuXXX
Copy link
Contributor

LuuuXXX commented Jul 8, 2024

@rustbot claim

@LuuuXXX LuuuXXX mentioned this issue Jul 16, 2024
Closed
@LuuuXXX LuuuXXX mentioned this issue Jul 25, 2024
Closed
@rustbot rustbot added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Feb 14, 2025
@Shourya742
Copy link
Contributor

@rustbot claim

@rustbot rustbot assigned Shourya742 and unassigned LuuuXXX Feb 14, 2025
This was referenced Feb 15, 2025
Closed
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#137081 - Shourya742:2025-02-15-change-confi…
58cee66 
…g.toml-to-bootstrap.toml, r=onur-ozkan

change config.toml to bootstrap.toml

Currently, both Bootstrap and Cargo uses same name as their configuration file, which can be confusing. This PR is based on a discussion to rename `config.toml` to `bootstrap.toml` for Bootstrap. Closes: rust-lang#126875.

I have split the PR into atomic commits to make it easier to review. Once the changes are finalized, I will squash them. I am particularly concerned about the changes made to modules that are not part of Bootstrap. How should we handle those changes? Should we ping the respective maintainers?
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#137081 - Shourya742:2025-02-15-change-confi…
d156259 
…g.toml-to-bootstrap.toml, r=onur-ozkan

change config.toml to bootstrap.toml

Currently, both Bootstrap and Cargo uses same name as their configuration file, which can be confusing. This PR is based on a discussion to rename `config.toml` to `bootstrap.toml` for Bootstrap. Closes: rust-lang#126875.

I have split the PR into atomic commits to make it easier to review. Once the changes are finalized, I will squash them. I am particularly concerned about the changes made to modules that are not part of Bootstrap. How should we handle those changes? Should we ping the respective maintainers?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shourya742 Shourya742

Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change config.toml to bootstrap.toml Shourya742/rust
6 participants
@jyn514 @onur-ozkan @LuuuXXX @rustbot @Noratrieb @Shourya742