-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Issue for Rust 2024: rustfmt style editions #123799
Comments
You can also add rust-lang/rustfmt#5933 to the implementation history |
note from today's t-style meet: use this one in the edition guide to provide additional/broader context around the style edition impacts, stability policy, etc. so that it doesn't needed to be repeated in other edition sections |
@rustbot labels +S-tracking-ready-for-edition We've reviewed, and this item is now ready for Rust 2024. Thanks to @calebcartwright, @ytmimi, and the rest of the rustfmt team for pushing forward this important work and making it ready for the edition. |
…r=ytmimi Stabilize `style_edition = "2024"` in-tree This PR stabilizes the `style_edition` flag in rustfmt. **Why am I doing this in-tree?** The beta release cut is imminent (according to forge, on January 3) and this is the most lightweight approach to getting this flag stable on nightly. It's imperative (as far as I can tell -- `@traviscross` can verify or disagree) that we stabilize the `style_edition` flag so that users can control their style edition separately from the edition. I'm happy to move this PR to the rustfmt repo and subsequently prepare a subtree sync if someone on `@rust-lang/rustfmt` believes that we should get this landed on the rustfmt side then synced. If this is the right recourse, I'd like to note that this is still quite time-sensitive. However, I'm happy to dedicate time to get this done if necessary, since I'd really like to un-jeopardize the style edition. Tracking: - rust-lang#123799
Stabilize `style_edition = "2024"` in-tree This PR stabilizes the `style_edition` flag in rustfmt. **Why am I doing this in-tree?** The beta release cut is imminent (according to forge, on January 3) and this is the most lightweight approach to getting this flag stable on nightly. It's imperative (as far as I can tell -- `@traviscross` can verify or disagree) that we stabilize the `style_edition` flag so that users can control their style edition separately from the edition. I'm happy to move this PR to the rustfmt repo and subsequently prepare a subtree sync if someone on `@rust-lang/rustfmt` believes that we should get this landed on the rustfmt side then synced. If this is the right recourse, I'd like to note that this is still quite time-sensitive. However, I'm happy to dedicate time to get this done if necessary, since I'd really like to un-jeopardize the style edition. Tracking: - rust-lang/rust#123799
This is a tracking issue for support for style editions in rustfmt. This is needed to support the Style Edition 2024 which is expected to be released with Rust 2024.
About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
style_edition = "2024"
in-tree #134929Unresolved Questions
None.
Related
StyleEdition
enum andStyleEditionDefault
trait rustfmt#5933StyleEditionDefault
trait for all configs rustfmt#5937cc @rust-lang/rustfmt @rust-lang/style @calebcartwright
The text was updated successfully, but these errors were encountered: