Skip to content

Commit

Permalink
Rollup merge of #137311 - martn3:enable-f16-mips, r=tgross35
Browse files Browse the repository at this point in the history
Enable `f16` for MIPS

Blocked on rust-lang/compiler-builtins#762

It seems as if `f16` works on MIPS now according to my testing on Rust master with LLVM 20, and I was asked [here](#137167 (comment)) to create PRs with my changes.

I only tested on the flavour of `mipsel-unknown-linux-gnu` hardware that happens to be available to me, so I can't say anything about other MIPS hardware, but from a casual skimming of the LLVM code ([1], [2]) it seems like `f16` should work on all MIPS hardware. So enable it for all MIPS hardware.

[1]: https://github.com/rust-lang/llvm-project/blob/rustc/20.1-2025-02-13/llvm/lib/Target/Mips/MipsISelLowering.h#L370
[2]: https://github.com/rust-lang/llvm-project/blob/rustc/20.1-2025-02-13/llvm/lib/CodeGen/TargetLoweringBase.cpp#L1367-L1388

`@rustbot` label +O-MIPS +F-f16_and_f128 +S-blocked

Tracking issue for f16: #116909

r? `@tgross35`
  • Loading branch information
fmease authored Feb 26, 2025
2 parents e121dcf + cf1242c commit 49249ea
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion library/std/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ fn main() {
("csky", _) => false,
("hexagon", _) => false,
("loongarch64", _) => false,
("mips" | "mips64" | "mips32r6" | "mips64r6", _) => false,
("powerpc" | "powerpc64", _) => false,
("sparc" | "sparc64", _) => false,
("wasm32" | "wasm64", _) => false,
Expand Down

0 comments on commit 49249ea

Please sign in to comment.