Skip to content

Commit

Permalink
Fix(lib/fs/tests): Disable rename POSIX semantics FS tests under Wind…
Browse files Browse the repository at this point in the history
…ows 7

Would otherwise fail there. The Windows7-specific parts were left pretty
much untouched by the changes introduced by
51df98d, so it is expected that these
tests fail under Windows 7 as they were probably written to run under
Windows 10+ only.

Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
  • Loading branch information
PaulDance committed Feb 21, 2025
1 parent 9f48ded commit 227107e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions library/std/src/fs/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1914,8 +1914,11 @@ fn test_hidden_file_truncation() {
assert_eq!(metadata.len(), 0);
}

// See https://github.com/matthiaskrgr/rust/commit/51df98ddb094b39b2e17d24f887cd66c52560ef6
// for more details about why these two tests are disabled under Windows 7 here.
#[cfg(windows)]
#[test]
#[cfg_attr(target_vendor = "win7", ignore = "Unsupported under Windows 7.")]
fn test_rename_file_over_open_file() {
// Make sure that std::fs::rename works if the target file is already opened with FILE_SHARE_DELETE. See #123985.
let tmpdir = tmpdir();
Expand All @@ -1940,6 +1943,7 @@ fn test_rename_file_over_open_file() {

#[test]
#[cfg(windows)]
#[cfg_attr(target_vendor = "win7", ignore = "Unsupported under Windows 7.")]
fn test_rename_directory_to_non_empty_directory() {
// Renaming a directory over a non-empty existing directory should fail on Windows.
let tmpdir: TempDir = tmpdir();
Expand Down

0 comments on commit 227107e

Please sign in to comment.